Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Composer is partially hidden on small mobile screens when keyboard is open #2628

Closed
matteocontrini opened this issue Feb 22, 2021 · 11 comments · Fixed by #2631
Closed

Composer is partially hidden on small mobile screens when keyboard is open #2628

matteocontrini opened this issue Feb 22, 2021 · 11 comments · Fixed by #2631
Assignees

Comments

@matteocontrini
Copy link
Contributor

matteocontrini commented Feb 22, 2021

Bug Report

Current Behavior

After #1670 was fixed, the composer is now fixed at the top of the screen on mobile. On small screens, this means that the keyboard could cover the composer and what you're trying to write.

This was also discussed in the PR (#2279), but I think the consequences were underestimated, because the new behaviour is a serious regression in the usability of the composer. Watch the video below to feel the frustration :)

Steps to Reproduce

  1. Go to nightly.flarum.site with a "small" screen (16:9 is probably enough)
  2. Attempt to write a long post
  3. Observe that you can't see what you're typing

Expected Behavior

There should definitely be a way to see what you're typing. Previously, it was possible to scroll to move the composer.

Screenshots

This video was provided by a user of my forum, where I cherry-picked and deployed the commit 9b27b0d.

20210222_220109.mp4

Environment

  • Flarum version: any version after 9b27b0d
@askvortsov1 askvortsov1 added this to the 0.1.0-beta.16 milestone Feb 22, 2021
@SychO9
Copy link
Member

SychO9 commented Feb 22, 2021

Thank you for reporting this!

@matteocontrini could you please go to nighly right now (before it's reset) and see if the issue still occurs ?

@matteocontrini
Copy link
Contributor Author

@SychO9 thanks for the fast reply :)

I asked my user with the small screen and he says he's not experiencing the issue on nightly.

@SychO9
Copy link
Member

SychO9 commented Feb 22, 2021

Great!

I'll push the fix later, thank you.

@matteocontrini
Copy link
Contributor Author

There's an additional problem caused by the fixed position of the modal, and it's the fact that you cannot scroll the mentions dropdown. (Feel free to skip the first 15 seconds of the video.)

video_2021-02-26_17-35-47.mp4

@askvortsov1
Copy link
Member

askvortsov1 commented Feb 26, 2021

Ooo, also the buttons for emoji/mentions are cut off. That's not ideal...
On the bright side, the mentions dropdown should no longer go above the top of the screen as part of the positioning changes associated with #2594

Thank you very much for finding these! Would have been quite annoying if they got into the release.

@SychO9
Copy link
Member

SychO9 commented Feb 26, 2021

Ooo, also the buttons for emoji/mentions are cut off. That's not ideal...

I believe that area is scrollable so it shouldn't be a problem

@matteocontrini
Copy link
Contributor Author

New problem reported by an iOS user, and he says it happens very often.

(Changes in #2631 were deployed to the forum some days ago.)

ezgif-com-video-to-gif

@SychO9
Copy link
Member

SychO9 commented Mar 2, 2021

Are both #2279 and #2631 applied ?

@matteocontrini
Copy link
Contributor Author

@SychO9 yes.

Here's another GIF. He says that it happens "almost every time".

@SychO9
Copy link
Member

SychO9 commented Mar 2, 2021

That's very odd, how come he is scrolling to the composer, when the composer is no longer absolute, it's as if #2279 is not applied, but it clearly is. I guess it's one of those weird iOS behaviours.

Could you please create a new issue about it until we can reproduce it and find a fix ?

@matteocontrini
Copy link
Contributor Author

Opened #2652.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants