-
-
Notifications
You must be signed in to change notification settings - Fork 834
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Composer is partially hidden on small mobile screens when keyboard is open #2628
Comments
Thank you for reporting this! @matteocontrini could you please go to nighly right now (before it's reset) and see if the issue still occurs ? |
@SychO9 thanks for the fast reply :) I asked my user with the small screen and he says he's not experiencing the issue on nightly. |
Great! I'll push the fix later, thank you. |
There's an additional problem caused by the fixed position of the modal, and it's the fact that you cannot scroll the mentions dropdown. (Feel free to skip the first 15 seconds of the video.) video_2021-02-26_17-35-47.mp4 |
Ooo, also the buttons for emoji/mentions are cut off. That's not ideal... Thank you very much for finding these! Would have been quite annoying if they got into the release. |
I believe that area is scrollable so it shouldn't be a problem |
New problem reported by an iOS user, and he says it happens very often. (Changes in #2631 were deployed to the forum some days ago.) |
@SychO9 yes. Here's another GIF. He says that it happens "almost every time". |
That's very odd, how come he is scrolling to the composer, when the composer is no longer absolute, it's as if #2279 is not applied, but it clearly is. I guess it's one of those weird iOS behaviours. Could you please create a new issue about it until we can reproduce it and find a fix ? |
Opened #2652. |
Bug Report
Current Behavior
After #1670 was fixed, the composer is now fixed at the top of the screen on mobile. On small screens, this means that the keyboard could cover the composer and what you're trying to write.
This was also discussed in the PR (#2279), but I think the consequences were underestimated, because the new behaviour is a serious regression in the usability of the composer. Watch the video below to feel the frustration :)
Steps to Reproduce
Expected Behavior
There should definitely be a way to see what you're typing. Previously, it was possible to scroll to move the composer.
Screenshots
This video was provided by a user of my forum, where I cherry-picked and deployed the commit 9b27b0d.
20210222_220109.mp4
Environment
The text was updated successfully, but these errors were encountered: