Slug Extender Test works

src/Http/HttpServiceProvider.php

@@ -50,10 +50,12 @@ public function register()
             $compiledDrivers = [];
 
             foreach ($this->app->make('flarum.http.slugDrivers') as $resourceClass => $resourceDrivers) {
-                $driverClass = $resourceDrivers[$settings->get("slug_driver_$resourceClass", 'default')];
-                echo 'AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA';
-                echo "slug_driver_$resourceClass";
-                //echo $settings->get("slug_driver_$resourceClass", 'default');
+                $driverKey = $settings->get("slug_driver_$resourceClass", 'default');
+                if (array_key_exists($driverKey, $resourceDrivers)) {
+                    $driverClass = $resourceDrivers[$driverKey];
+                } else {
+                    $driverClass = $resourceDrivers['default'];
+                }
                 $compiledDrivers[$resourceClass] = $this->app->make($driverClass);
             }
 
@@ -70,14 +72,14 @@ public function register()
                     ]);
                 },
                 Post::class => function (UrlGenerator $urlGenerator, Post $post) use ($slugManager) {
-                    return $urlGenerator->to('forum')->route('user', [
+                    return $urlGenerator->to('forum')->route('post', [
                         'id' => $slugManager->forResource(Discussion::class)->toSlug($post->discussion),
                         'near' => $post->id,
                     ]);
                 },
                 User::class => function (UrlGenerator $urlGenerator, User $user) use ($slugManager) {
                     return $urlGenerator->to('forum')->route('user', [
-                        'id' => $slugManager->forResource(User::class)->toSlug($user)
+                        'username' => $slugManager->forResource(User::class)->toSlug($user)
                     ]);
                 },
             ];

src/Http/UrlGenerator.php

@@ -79,8 +79,6 @@ public function toResource(string $resourceClass, AbstractModel $instance, ...$a
     {
         $callback = $this->resourceUrlGenerators[$resourceClass];
 
-        $result = $callback($this, $instance, ...$args);
-
-        return $result;
+        return $callback($this, $instance, ...$args);
     }
 }

tests/integration/extenders/ModelUrlTest.php

@@ -14,6 +14,7 @@
 use Flarum\Http\SlugDriverInterface;
 use Flarum\Http\SlugManager;
 use Flarum\Http\UrlGenerator;
+use Flarum\Settings\SettingsRepositoryInterface;
 use Flarum\Tests\integration\RetrievesAuthorizedUsers;
 use Flarum\Tests\integration\TestCase;
 use Flarum\User\User;
@@ -24,35 +25,18 @@ class ModelUrlTest extends TestCase
 
     protected function prepDb()
     {
+        $userClass = User::class;
         $this->prepareDatabase([
             'users' => [
                 $this->adminUser(),
                 $this->normalUser(),
             ],
-        ]);
-    }
-
-    protected function activateCustomDriver()
-    {
-        $userClass = User::class;
-        $this->prepareDatabase([
             'settings' => [
                 ['key' => "slug_driver_$userClass", 'value' => 'testDriver'],
-            ],
+            ]
         ]);
     }
 
-//    public function tearDown()
-//    {
-//        $userClass = User::class;
-//        $this->prepareDatabase([
-//            'settings' => [
-//                ['key' => "slug_driver_$userClass", 'value' => 'default'],
-//            ],
-//        ]);
-//        parent::tearDown();
-//    }
-
     /**
      * @test
      */
@@ -102,29 +86,11 @@ public function uses_default_driver_by_default()
     /**
      * @test
      */
-    public function custom_slug_driver_doesnt_have_effect_unless_enabled()
-    {
-        $this->extend((new Extend\ModelUrl(User::class))->addSlugDriver('testDriver', TestSlugDriver::class));
-
-        $this->prepDb();
-
-        $slugManager = $this->app()->getContainer()->make(SlugManager::class);
-
-        $testUser = User::find(1);
-
-        $this->assertEquals('admin', $slugManager->forResource(User::class)->toSlug($testUser));
-        $this->assertEquals('1', $slugManager->forResource(User::class)->fromSlug('admin', $testUser)->id);
-    }
-
-    /**
-     * @test
-     */
-    public function custom_slug_driver_has_effect_if_enabled()
+    public function custom_slug_driver_has_effect_if_added()
     {
         $this->extend((new Extend\ModelUrl(User::class))->addSlugDriver('testDriver', TestSlugDriver::class));
 
         $this->prepDb();
-        $this->activateCustomDriver();
 
         $slugManager = $this->app()->getContainer()->make(SlugManager::class);