Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Slug Driver Support #2456

Merged
merged 22 commits into from
Dec 7, 2020
Merged

Slug Driver Support #2456

Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
44902e9
Initial Driver Support (No Extender)
tankerkiller125 Nov 17, 2020
668962d
Apply fixes from StyleCI
luceos Nov 17, 2020
0358161
Fix user ShowTests
askvortsov1 Nov 19, 2020
0fc6dfc
Format
askvortsov1 Nov 19, 2020
79721bc
WIP Extender
tankerkiller125 Nov 24, 2020
1d260b9
Apply fixes from StyleCI
luceos Nov 24, 2020
45db62e
Slug Extender Test works
tankerkiller125 Nov 24, 2020
4791741
Apply fixes from StyleCI
luceos Nov 24, 2020
421aabd
Working Admin Page
tankerkiller125 Nov 24, 2020
adc2fce
Made frontend discussion slug independent
tankerkiller125 Nov 24, 2020
ca1efe0
Apply fixes from StyleCI
luceos Nov 24, 2020
be42a0b
Make min search length a constant
tankerkiller125 Nov 24, 2020
2c0afc2
Fix some review issues
tankerkiller125 Nov 27, 2020
7b9e829
Use Repositories instead of models
tankerkiller125 Nov 30, 2020
a9ab7e4
Apply fixes from StyleCI
luceos Nov 30, 2020
c90ea80
Remote UrlGenerator toResource
tankerkiller125 Nov 30, 2020
5ea83f7
Apply fixes from StyleCI
luceos Nov 30, 2020
60edecc
Fixing UserRepository
tankerkiller125 Nov 30, 2020
6e255f8
Trying process isolation to fix weird test bug
tankerkiller125 Nov 30, 2020
2ac869f
Try to fix test
tankerkiller125 Nov 30, 2020
1db1d11
Fix parameter order
askvortsov1 Dec 2, 2020
572e5a4
Clean up ternary
askvortsov1 Dec 5, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix parameter order
  • Loading branch information
@askvortsov1
askvortsov1 committed Dec 2, 2020
commit 1db1d11e37f81c5fa8e954ffa450efe43420f186
13 changes: 7 additions & 6 deletions src/Api/Controller/ShowDiscussionController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,14 +33,14 @@ class ShowDiscussionController extends AbstractShowController
protected $posts;

/**
* {@inheritdoc}
* @var SlugManager
*/
public $serializer = DiscussionSerializer::class;
protected $slugManager;

/**
* @var SlugManager
* {@inheritdoc}
*/
protected $slugManager;
public $serializer = DiscussionSerializer::class;

/**
* {@inheritdoc}
Expand All @@ -67,12 +67,13 @@ class ShowDiscussionController extends AbstractShowController
/**
* @param \Flarum\Discussion\DiscussionRepository $discussions
* @param \Flarum\Post\PostRepository $posts
* @param \Flarum\Http\SlugManager $slugManager
*/
public function __construct(SlugManager $slugManager, DiscussionRepository $discussions, PostRepository $posts)
public function __construct(DiscussionRepository $discussions, PostRepository $posts, SlugManager $slugManager)
{
$this->slugManager = $slugManager;
$this->discussions = $discussions;
$this->posts = $posts;
$this->slugManager = $slugManager;
}

/**
Expand Down