Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use drivers for display names, add display name extender #2174

Merged
merged 12 commits into from
May 19, 2020
Merged

Use drivers for display names, add display name extender #2174

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
8032578
Deprecate GetDisplayName event
askvortsov1 May 18, 2020
1007fe6
Add interface for display name driver
askvortsov1 May 18, 2020
ee8f865
Add username driver as default
askvortsov1 May 18, 2020
dbdd1ac
Add code to register supported drivers / used driver as singletons
askvortsov1 May 18, 2020
ea9e765
Configured User class to use new driver-based system for display names
askvortsov1 May 18, 2020
d348ce1
Add extender for adding display name driver
askvortsov1 May 18, 2020
b82ce7a
Add integration test for user display name driver
askvortsov1 May 18, 2020
489abb0
Add frontend UI for selecting display name driver
askvortsov1 May 18, 2020
9e3ec30
Fix frontend saving numerical index vs identifier of selected driver
askvortsov1 May 18, 2020
fc5f294
Improve how displayNameOptions are assembled, don't include unused nu…
askvortsov1 May 19, 2020
daf5202
Add display name text to basics page display name section
askvortsov1 May 19, 2020
9cc3a39
Apply fixes from StyleCI
luceos May 19, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix frontend saving numerical index vs identifier of selected driver
  • Loading branch information
@askvortsov1
askvortsov1 committed May 18, 2020
commit 9e3ec3094ccae7d37eb775859cea3d326e3c5ff8
2 changes: 1 addition & 1 deletion js/src/admin/components/BasicsPage.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ export default class BasicsPage extends Page {
this.displayNameOptions = {};
const displayNameDrivers = app.data.displayNameDrivers;
for (const i in displayNameDrivers) {
this.displayNameOptions[i] = `${displayNameDrivers[i]} (${i})`;
this.displayNameOptions[displayNameDrivers[i]] = `${displayNameDrivers[i]} (${i})`;
}

if (!this.values.display_name_driver() && displayNameDrivers.includes('username')) this.values.display_name_driver('username');
Expand Down