Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use drivers for display names, add display name extender #2174

Merged
merged 12 commits into from
May 19, 2020

Conversation

askvortsov1
Copy link
Member

**Part of #2091, #1891 **

Changes proposed in this pull request:

  • Deprecate GetDisplayName event
  • Use drivers for display name
  • Add extender for adding display name driver
  • Add integration tests for extender
  • Add frontend ui for

Reviewers should focus on:

  • Is there a better place to put the driver UI than the basics page?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).

@askvortsov1 askvortsov1 force-pushed the as/display_name_extender_and_driver branch from eca5d90 to fc5f294 Compare May 19, 2020 22:36
@askvortsov1 askvortsov1 force-pushed the as/display_name_extender_and_driver branch from 94485c9 to daf5202 Compare May 19, 2020 22:41
[ci skip] [skip ci]
@askvortsov1 askvortsov1 merged commit b0822df into master May 19, 2020
@askvortsov1 askvortsov1 deleted the as/display_name_extender_and_driver branch May 19, 2020 22:45
@askvortsov1 askvortsov1 added this to the 0.1.0-beta.14 milestone May 19, 2020
askvortsov1 added a commit to askvortsov1/lang-english that referenced this pull request May 19, 2020
askvortsov1 added a commit to flarum/lang-english that referenced this pull request May 19, 2020
@franzliedke franzliedke mentioned this pull request May 20, 2020
78 tasks
realodix added a commit to realodix/flarum-ext-indonesian that referenced this pull request Jun 1, 2020
@luceos
Copy link
Member

luceos commented Jun 29, 2020

There's a bug in this code @askvortsov1 ; the property is $displayNameDrivers, but it is nowhere used in the User extender.

@askvortsov1
Copy link
Member Author

Hmm, odd that the tests still worked... Nevertheless, fixed in aaebd35

realodix added a commit to realodix/flarum-ext-indonesian that referenced this pull request Oct 22, 2020
* Companion changes for flarum/framework#2174

flarum/lang-english@bbe8661

* Add meta title to following page

flarum/lang-english@0314092

* Remove SES translations

flarum/lang-english@26ea112#diff-fd1b8443415c3f3a058d04812d1e90edL108

* Update core.yml

Sebelumnya 3b4fe66

* Add 'all discussions' meta title

flarum/lang-english@275272d

* Remove locales for Mandrill mail driver

flarum/lang-english@a313775

* Added translations for Send Test Mail feature

flarum/lang-english@ea79027

* Add missing full stop for some validation messages

flarum/lang-english@19f4263

* Add new password rule language line

flarum/lang-english@5a071d9

* Strings containing specific characters must be quoted

flarum/lang-english@3e91255

* Translate emails for subscriptions

flarum/lang-english@80d30ea

* Update flarum-subscriptions.yml

* Translate emails for mentions

flarum/lang-english@23b6fa9

* Add extension dependency error translations

flarum/lang-english@327d12e

* fof/drafts  v0.1.3

https://github.com/FriendsOfFlarum/drafts/releases/tag/0.1.13

* fof/gamification v0.2.6

FriendsOfFlarum/gamification@0.2.4...0.2.6

* fof/reactions v0.3.4

FriendsOfFlarum/reactions@0.2.4...0.3.4#diff-b33d460533a55cc7bc6acc9fd193dcf2

* Update ext-kyrne-shout.yml

KyrneDev/Shout-public@0.1.16...0.2.3#diff-b33d460533a55cc7bc6acc9fd193dcf2

* michaelbelgium/flarum-profile-views v3.1.0

MichaelBelgium/flarum-profile-views@v2.1.6...v3.1.0#diff-fe5a1eb4b513afa3b7751c871a4bd3c7

* fof/discussion-language v0.1.2

* Update README.md

* Update composer.json

* Update core.yml

* Update core.yml
askvortsov1 added a commit to flarum/lang-english that referenced this pull request Mar 11, 2022
askvortsov1 added a commit to flarum/lang-english that referenced this pull request May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants