Increasing test coverage #1711
Merged
Increasing test coverage #1711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@luceos Still WIP or ready to go? |
|
Let me add the error reporting level as a todo here before we merge @franzliedke |
|
Okay, great: 👍 |
|
@franzliedke added: https://travis-ci.org/flarum/core/jobs/470697812#L660 |
|
Ready to be merged if green ;) |
tobyzerner
approved these changes
Dec 20, 2018
franzliedke
reviewed
Dec 20, 2018
|
Merging for now - I want to work on restructuring the tests a bit. |
wzdiyb
pushed a commit
to wzdiyb/core
that referenced
this pull request
Feb 16, 2020
* added a few more tests, renamed singular to plural to match controller * increase error reporting * removed debugging and wait for tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Confirmed
Frontend changes: tested on a local Flarum installation.php vendor/bin/phpunit).