Increasing test coverage (#1711)

* added a few more tests, renamed singular to plural to match controller

* increase error reporting

* removed debugging and wait for tests

.travis.yml

@@ -9,6 +9,9 @@ install:
   - composer install
   - mysql -e 'CREATE DATABASE flarum;'
 
+before_script:
+  - echo 'error_reporting = E_ALL' >> ~/.phpenv/versions/$(phpenv version-name)/etc/conf.d/travis.ini
+
 script:
   - vendor/bin/phpunit --coverage-clover=coverage.xml
 

tests/Api/Controller/ListDiscussionControllerTest.php → tests/Api/Controller/ListDiscussionsControllerTest.php

@@ -14,7 +14,7 @@
 use Flarum\Api\Controller\ListDiscussionsController;
 use Flarum\Discussion\Discussion;
 
-class ListDiscussionControllerTest extends ApiControllerTestCase
+class ListDiscussionsControllerTest extends ApiControllerTestCase
 {
     protected $controller = ListDiscussionsController::class;
 

tests/Api/Controller/ListGroupsControllerTest.php

@@ -0,0 +1,33 @@
+<?php
+
+/*
+ * This file is part of Flarum.
+ *
+ * (c) Toby Zerner <toby.zerner@gmail.com>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+namespace Flarum\Tests\Api\Controller;
+
+use Flarum\Api\Controller\ListGroupsController;
+use Flarum\Group\Group;
+
+class ListGroupsControllerTest extends ApiControllerTestCase
+{
+    protected $controller = ListGroupsController::class;
+
+    /**
+     * @test
+     */
+    public function shows_index_for_guest()
+    {
+        $response = $this->callWith();
+
+        $this->assertEquals(200, $response->getStatusCode());
+        $data = json_decode($response->getBody()->getContents(), true);
+
+        $this->assertEquals(Group::count(), count($data['data']));
+    }
+}

tests/Api/Controller/ListNotificationsControllerTest.php

@@ -0,0 +1,40 @@
+<?php
+
+/*
+ * This file is part of Flarum.
+ *
+ * (c) Toby Zerner <toby.zerner@gmail.com>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+namespace Flarum\Tests\Api\Controller;
+
+use Flarum\Api\Controller\ListNotificationsController;
+
+class ListNotificationsControllerTest extends ApiControllerTestCase
+{
+    protected $controller = ListNotificationsController::class;
+
+    /**
+     * @test
+     * @expectedException \Flarum\User\Exception\PermissionDeniedException
+     */
+    public function disallows_index_for_guest()
+    {
+        $this->callWith();
+    }
+
+    /**
+     * @test
+     */
+    public function show_index_for_user()
+    {
+        $this->actor = $this->getNormalUser();
+
+        $response = $this->callWith();
+
+        $this->assertEquals(200, $response->getStatusCode());
+    }
+}

tests/Api/Controller/ListUsersControllerTest.php

@@ -0,0 +1,40 @@
+<?php
+
+/*
+ * This file is part of Flarum.
+ *
+ * (c) Toby Zerner <toby.zerner@gmail.com>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+namespace Flarum\Tests\Api\Controller;
+
+use Flarum\Api\Controller\ListUsersController;
+
+class ListUsersControllerTest extends ApiControllerTestCase
+{
+    protected $controller = ListUsersController::class;
+
+    /**
+     * @test
+     * @expectedException \Flarum\User\Exception\PermissionDeniedException
+     */
+    public function disallows_index_for_guest()
+    {
+        $this->callWith();
+    }
+
+    /**
+     * @test
+     */
+    public function shows_index_for_admin()
+    {
+        $this->actor = $this->getAdminUser();
+
+        $response = $this->callWith();
+
+        $this->assertEquals(200, $response->getStatusCode());
+    }
+}