Fixing #2684 - broken flameshot icon in about window #2693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@RiedleroD Thanks. what distro do you use? |
|
@mmahmoudian base arch 5.18.5 with sway 1.7 and QtSVG 5.15.5+kde+r10 |
|
Just tested. Looks good.
LOL yes welcome to our nightmare. TBH I like using Linux the best, but my favorite platform to release for is MacOS |
panpuchkov
pushed a commit
to namecheap/flameshot
that referenced
this pull request
Jun 26, 2022
(cherry picked from commit dcb1291)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed missing workaround for the arc flag parsing bug in QtSVG and older versions of rsvg
let's see if that actually fixes #2684
also, just for the record: my local installation of Qt5SVG renders both versions correctly. No idea what weird versions your stable distros all have 🤷🏻♂️