Regression: broken flameshot icon in about window ( caused by #2318 )

[hosiet]

Flameshot Version

12.0-rc1

Installation Type

Linux, MacOS, or Windows Package manager (apt, pacman, eopkg, choco, brew, ...)

Operating System type and version

Debian Sid / Unstable

Description

The flameshot icon in about window is broken. Meanwhile, stderr has multiple output of "qt.svg: Invalid path data; path truncated.".

I believe current SVG icon has some incompatibilities with Qt5's SVG library. We all know that in #2318 the SVG icon was manually "optimized". When reverting the icon to un-optimized version (flameshot.svg and org.flameshot.Flameshot.svg from https://github.com/flameshot-org/flameshot/tree/9752b975c132056cb0fb5add4d28bf5c60ef6d84/data/img/app ), everything works well again. I am using the most up-to-date Qt5 LTS version (5.15.4) so I believe we should make things compatible with this Qt version.

Ping original author @RiedleroD so that you may look further into it.

Steps to reproduce

1. Run /usr/bin/flameshot.
2. Open "About" dialog from tray icon.

Screenshots or screen recordings

System Information

• Debian Sid/Unstable
• Qt 5.15.4
• Desktop environment: (reproducible on all major Desktop Environments, including MATE and KDE Plasma)
• X11 environment

[mmahmoudian]

This is similar to #2667 but of course not duplicate.

[borgmanJeremy]

I'll revert the SVG.

[RiedleroD]

oh, this was actually my fault (for not fully correcting for known bugs in QtSVG)

I'll open a PR with the paths fixed & you'll see if that fixes is, ok?

also I don't particularly like how you put "optimized" in quotes, but I don't want to start drama over this.