Skip to content

Deprecate authors for ThePortugalNews #845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MaxDall wants to merge 2 commits into
base: check-coverage-script
Choose a base branch
from
Open

Deprecate authors for ThePortugalNews #845

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
052c94d
deprecate `topics` for `ThePortugalNews`
MaxDall Dec 10, 2025
444ecb5
update tables
MaxDall Dec 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion docs/supported_publishers.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2736,7 +2736,9 @@
<td>
<code>topics</code>
</td>
<td>&#160;</td>
<td>
<code>authors</code>
</td>
<td>&#160;</td>
</tr>
</tbody>
Expand Down
2 changes: 1 addition & 1 deletion src/fundus/publishers/pt/the_portugal_news.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ def publishing_date(self) -> Optional[datetime.datetime]:
def title(self) -> Optional[str]:
return self.precomputed.ld.bf_search("headline")

@attribute
@attribute(deprecated=datetime.date(2025, 10, 21))
Copy link
Collaborator

@addie9800 addie9800 Dec 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it needs to be deprecated, just updated. Some article types, such as opinion pieces still have parsable, non-generic authors. e.g. 1, 2

Copy link
Collaborator Author

@MaxDall MaxDall Dec 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, maybe we need a now category for attributes that rarely occurre? Otherwise this will fail the publisher coverage all the time.

def authors(self) -> List[str]:
author_objects = self._author_selector(self.precomputed.doc)
if author_objects and (author := re.search(r"(?i)by\s*(?P<authors>.*),[\r\sr\n]*in", author_objects[0])):
Expand Down