Skip to content

Conversation

@MaxDall
Copy link
Collaborator

@MaxDall MaxDall commented Dec 10, 2025

Deprecates the authors attribute for the ThePortugalNews

@MaxDall MaxDall requested a review from addie9800 December 10, 2025 16:23
@MaxDall MaxDall changed the title Deprecate topics for ThePortugalNews Deprecate authors for ThePortugalNews Dec 10, 2025
Copy link
Collaborator

@addie9800 addie9800 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this 👍

return self.precomputed.ld.bf_search("headline")

@attribute
@attribute(deprecated=datetime.date(2025, 10, 21))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it needs to be deprecated, just updated. Some article types, such as opinion pieces still have parsable, non-generic authors. e.g. 1, 2

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, maybe we need a now category for attributes that rarely occurre? Otherwise this will fail the publisher coverage all the time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants