Fix deprecation warnings #1119
Merged
Fix deprecation warnings #1119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maringuu
requested changes
Sep 1, 2023
src/conftest.py
Outdated
| import pytest | ||
| from pydantic import BaseModel, Field | ||
| from pydantic.utils import deep_update | ||
| from pydantic.v1 import ConfigDict |
Collaborator
There was a problem hiding this comment.
Why do we need this, what is the v2 way of doing things?
Collaborator
Author
There was a problem hiding this comment.
Hmm weird. According to the docs you can directly import it from pydantic:
from pydantic import BaseModel, ConfigDict
class Model(BaseModel):
model_config = ConfigDict(str_max_length=10)Maybe I used the auto import fix in pycharm.
jstucke
added a commit
that referenced
this pull request
Dec 2, 2025
since the changes in #1119 Markup (which was previously imported from flask) only depends on MarkupSafe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The last scheduled master CI build had 43624 warnings when running the tests. This PR should reduce this number to less than 30. There are some warnings that can't be fixed because they are caused by dependencies or where it is too complicated (the crypto_hints plugin should be fixed in its own PR).