Skip to content

Typescript support v2 topic pq #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 27, 2019
Merged

Typescript support v2 topic pq #57

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0a54e4d
pq for v2 edits
vabruzzo Feb 27, 2019
5221d19
bump scripts pq test
vabruzzo Feb 27, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
"react-scripts": "./bin/react-scripts.js"
},
"engines": {
"node": "^6.0.0",
"node": ">=6.0.0",
"yarn": "^1.6.0"
},
"dependencies": {
Expand Down
2 changes: 1 addition & 1 deletion scripts/build.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ function handler(config, err, stats) {
console.log('Compiling relay queries...');
const relayCompiler = spawn(
path.resolve('./node_modules/.bin/relay-compiler'),
relayCompilerArguments,
relayCompilerArguments.concat('--watchman', 'false'),
Copy link
Contributor Author

@vabruzzo vabruzzo Feb 27, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

relay annoyingly now throws an error instead of a warning if watchman isnt on PATH, prevent that during builds

{ stdio: 'inherit' },
);

Expand Down
2 changes: 1 addition & 1 deletion scripts/utils/relayCompilerArguments.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,5 +33,5 @@ module.exports = [
'--artifactDirectory',
'src/__generated__',

process.env.PERSIST_QUERIES ? '--persist' : '',
process.env.PERSIST_QUERIES ? '--persist --persist-output' : '',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the official relay persisted queries code didnt change much, except for this. passing both for now to support older projects using the forked version (we should make tickets to update those projects soon)

].reduce((acc, item) => acc.concat(item), []);