Typescript support v2 topic pq #57
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vabruzzo
commented
Feb 27, 2019
| @@ -53,7 +53,7 @@ function handler(config, err, stats) { | |||
| console.log('Compiling relay queries...'); | |||
| const relayCompiler = spawn( | |||
| path.resolve('./node_modules/.bin/relay-compiler'), | |||
| relayCompilerArguments, | |||
| relayCompilerArguments.concat('--watchman', 'false'), | |||
There was a problem hiding this comment.
relay annoyingly now throws an error instead of a warning if watchman isnt on PATH, prevent that during builds
vabruzzo
commented
Feb 27, 2019
| @@ -33,5 +33,5 @@ module.exports = [ | |||
| '--artifactDirectory', | |||
| 'src/__generated__', | |||
|
|
|||
| process.env.PERSIST_QUERIES ? '--persist' : '', | |||
| process.env.PERSIST_QUERIES ? '--persist --persist-output' : '', | |||
There was a problem hiding this comment.
the official relay persisted queries code didnt change much, except for this. passing both for now to support older projects using the forked version (we should make tickets to update those projects soon)
carlyle
approved these changes
Feb 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.