Skip to content

codec bug #364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 18, 2017
Merged

codec bug #364

merged 2 commits into from
Mar 18, 2017

Conversation

zfields
Copy link
Contributor

@zfields zfields commented Mar 18, 2017

@zfields
Copy link
Contributor Author

zfields commented Mar 18, 2017

I have tested this on all my platforms, and for backward compatibility with 2.5.4.

@soundanalogous
Copy link
Member

soundanalogous commented Mar 18, 2017

I didn't run #359 through my manual tests or I would have caught this. Lesson learned. It's also time we added a string parser test to firmata_test.ino.

@soundanalogous
Copy link
Member

See page 29 of this pdf. This is the circuit I use to test several features at once (adc, pwm, servo, digital on digital pins, digital I/O on analog pins, I2C read, I2C write). I should really get this made into a shield at some point so other contributors can test with the same setup (and then port the demo app to their respective client libraries). I use Breakout.js for this particular test. The code is here (in case you wanted to create an equivalent example for remote-wiring).

@soundanalogous
Copy link
Member

Ran through my tests and all is good.

@soundanalogous soundanalogous merged commit f18eb75 into firmata:master Mar 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants