Skip to content

Firmata strings encoded incorrectly #363

Closed
@zfields

Description

@zfields

This needs a patch rev [v2.5.6]. I encoded Firmata strings directly (not as two bytes), including the Firmware name, but I couldn't detect it because it is ASCII (7-bits), and I had parsed the firmware name incorrectly.

I was refactoring the parser's firmware string decoder to use your logic for strings, when I realized what I had done.

I have the pull request ready to patch...

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions