cmake: enable more warnings for consistency across platforms #1990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This moves functions for reading CAD files into shared.
When compiling under strict mode (STRICT_CHECKS=ON) enable more checks. Disable some checks that currently result in too many errors. This also addresses two warnings.
|
NB: |
JakeOShannessy
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
STRICT_CHECKSisONthis enables many more checks.This PR also make minor changes to address these. The most significant of these is
-Wshadow(previously I used shaddowed variables a fair bit). Sufficing_localor_argused when there is a global of the same name.This depends on #1987, so shouldn't be considered until that PR is resolved.