move CAD reading functions to shared

[JakeOShannessy]

This moves functions for reading CAD files into shared.

There aren't many examples of this in the Verification cases so while the functionality is maintained there isn't much to verify it.

[gforney]

i'm getting this warning
../../../Source//smokeview/readsmv.c:9278:14: warning: unused variable 'len' [-Wunused-variable]
9278 | size_t len;

[JakeOShannessy]

Addressed. I've also tweaked some the warnings levels I have set to try and match what you're using. (They can't be turned on 100% at this point).

[gforney]

I've never been able to figure out how to get any one compiler to spit out the warnings that are completely useful. the warning I noted was reported by the gnu compiler in a virtual ubuntu session. visual studio was fine with this in debug mode - did not report the warning. but if I up the level in visual studio I get blasted with a ton of mostly useless warnings

…

On Wed, Aug 14, 2024 at 3:51 PM JakeOShannessy ***@***.***> wrote: Addressed. I've also tweaked some the warnings levels I have set to try and match what you're using. (They can't be turned on 100% at this point). — Reply to this email directly, view it on GitHub <#1987 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AC6UCRRLO3ZUG74SXOD7RZDZROYMXAVCNFSM6AAAAABMO2LKWWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOBZG42DSNBRHA> . You are receiving this because you commented.Message ID: ***@***.***>

-- Glenn Forney

[JakeOShannessy]

Yeah it's a bit of a battle to get a consistent set of warnings across platforms. I'm tweaking the cmake as I go. I've just enabled -Wshadow as I've noted it's something you addressed in the other PR.

[gforney]

Another example of inconsistent warnings. Smokebot caught that one on our linux cluster but gnu gcc on my virtual Ubuntu computer didnt

…

On Wed, Aug 14, 2024, 5:18 PM JakeOShannessy ***@***.***> wrote: Yeah it's a bit of a battle to get a consistent set of warnings across platforms. I'm tweaking the cmake as I go. I've just enabled -Wshadow as I've noted it's something you addressed in the other PR. — Reply to this email directly, view it on GitHub <#1987 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AC6UCRQDKOXOQY7BSARIYFLZRPCTJAVCNFSM6AAAAABMO2LKWWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOBZHEZDENZSGE> . You are receiving this because you commented.Message ID: ***@***.***>