Skip to content

Make the range duration text white again#5792

Merged
mstange merged 1 commit intofirefox-devtools:mainfrom
canova:range-duration-color
Jan 28, 2026
Merged

Make the range duration text white again#5792
mstange merged 1 commit intofirefox-devtools:mainfrom
canova:range-duration-color

Conversation

@canova
Copy link
Member

@canova canova commented Jan 28, 2026

Fixes #5791

Before:
Screenshot 2026-01-28 at 5 49 40 PM

After:
Screenshot 2026-01-28 at 6 05 42 PM

Dark mode is still the same:
Screenshot 2026-01-28 at 6 15 22 PM

Example profile: before / after

@canova canova requested review from fatadel and mstange January 28, 2026 17:18
@codecov
Copy link

codecov bot commented Jan 28, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.62%. Comparing base (35c005e) to head (34edaa4).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5792   +/-   ##
=======================================
  Coverage   85.62%   85.62%           
=======================================
  Files         319      319           
  Lines       31247    31247           
  Branches     8510     8596   +86     
=======================================
  Hits        26756    26756           
  Misses       4061     4061           
  Partials      430      430           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@canova canova force-pushed the range-duration-color branch from 2f3a8b7 to 34edaa4 Compare January 28, 2026 17:25
Copy link
Contributor

@mstange mstange left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I just noticed that today too

@mstange mstange merged commit a678202 into firefox-devtools:main Jan 28, 2026
21 checks passed
@canova canova mentioned this pull request Feb 4, 2026
canova added a commit that referenced this pull request Feb 4, 2026
Changes:

[Nazım Can Altınova] Make the range duration text white again (#5792)
[Alex Thayer] Display traced values in Stack Chart view (#5363)
[Nazım Can Altınova] Improve the JS traced arguments visualization in
call node tooltips (#5795)
[Markus Stange] Make the argument-values.json profile fixture go through
profile upgrading (#5796)
[Markus Stange] Add thread.usedInnerWindowIDs to the processed profile
format (#5780)
[fatadel] Fix context menu and hover preview z-index (#5797)
[fatadel] add TrackPower--tooltip-power-microwatt (#5799)
[Markus Stange] Two small test fixes (#5801)
[fatadel] fix selected thread pid color in light mode (#5805)
[Markus Stange] Some fixes to the profile merging code (#5802)
[fatadel] fix disabled button color in dark mode (#5808)
[fatadel] add comment for uptime label translation (#5806)
[Nazım Can Altınova] Add a theme toggle to the home page and follow the
system theme by default (#5800)
[Nazım Can Altınova] 🔃 Sync: l10n -> main (Feb 4, 2025) (#5813)

And huge thanks to our localizers:

de: Ger
de: Michael Köhler
de: Nazım Can Altınova
el: Jim Spentzos
en-GB: Ian Neal
es-CL: ravmn
fy-NL: Fjoerfoks
ia: Melo46
it: Francesco Lodolo [:flod]
nl: Mark Heijl
pt-BR: Marcelo Ghelman
ru: Valery Ledovskoy
sv-SE: Andreas Pettersson
tr: Selim Şumlu
zh-TW: Pin-guang Chen
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The range duration on the timeline selection has incorrect text color

2 participants