Incorporate TinyASM into Firedrake #3604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JHopeCollins
previously requested changes
Jun 4, 2024
JHopeCollins
changed the title
|
TODO (perhaps)? Ask @florianwechsung what license is appropriate. I made some non-substantive changes (many years ago) that I am happy to license under whatever. |
Merged
|
Good catch Lawrence. We need to ask Florian for a licence. LGPL would match the rest of Firedrake. MIT would also be fine. |
|
Happy to see TinyASM being moved into firedrake! LGPL is good with me. |
JDBetteridge
force-pushed
the
JDBetteridge/incorperate_tinyasm
branch
from
1119789
to
d220fb7
Compare
JHopeCollins
approved these changes
Jun 7, 2024
dham
approved these changes
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Move TinyASM into Firedrake. Later job is to rewrite in C, but for now keep as C++ and use pybind11.
python -c "import tinyasm"segfaults, but this happened before 🙁