-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorporate TinyASM into Firedrake #3604
Conversation
TODO (perhaps)? Ask @florianwechsung what license is appropriate. I made some non-substantive changes (many years ago) that I am happy to license under whatever. |
Good catch Lawrence. We need to ask Florian for a licence. LGPL would match the rest of Firedrake. MIT would also be fine. |
Happy to see TinyASM being moved into firedrake! LGPL is good with me. |
1119789
to
d220fb7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Firedrake is already under LGPL, so if this license is satisfactory then no extra license text is needed.
Description
Move TinyASM into Firedrake. Later job is to rewrite in C, but for now keep as C++ and use pybind11.
python -c "import tinyasm"
segfaults, but this happened before 🙁