Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDBetteridge/python312 #3546

Merged
merged 62 commits into from
Jun 20, 2024
Merged

JDBetteridge/python312 #3546

merged 62 commits into from
Jun 20, 2024

Conversation

JDBetteridge
Copy link
Member

@JDBetteridge JDBetteridge commented May 1, 2024

Description

This is now ready to land, once numpy 2.0 is released on 16th June

https://numpy.org/news/#numpy-20-release-date-june-16

Linked PRs:

Code Coverage

Code coverage can be re-enabled when Ubuntu 24.04 updates to Python 3.12.4, see python/cpython#119118 for the performance regression

@JDBetteridge JDBetteridge force-pushed the JDBetteridge/python312 branch 3 times, most recently from 7dd24b1 to 7513306 Compare May 10, 2024 11:21
@JDBetteridge JDBetteridge linked an issue May 13, 2024 that may be closed by this pull request
@rckirby
Copy link
Contributor

rckirby commented Jun 4, 2024

FYI, I went ahead and did the FIAT merge. Nothing was changed pointing to various numpy versions. All it had was np.factorial replaced by math.factorial which won't break anything.

dham
dham previously requested changes Jun 19, 2024
Copy link
Member

@dham dham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rebase and lose branches of pytorch and thetis.

scripts/firedrake-install Outdated Show resolved Hide resolved
scripts/firedrake-install Outdated Show resolved Hide resolved
Copy link
Contributor

@connorjward connorjward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please update page about 3.8 and also mumble mumble ARM support (to badly quote @JDBetteridge)

connorjward
connorjward previously approved these changes Jun 20, 2024
Copy link
Contributor

@connorjward connorjward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks good to me!

@JDBetteridge JDBetteridge merged commit 70e6b79 into master Jun 20, 2024
9 checks passed
@JDBetteridge JDBetteridge deleted the JDBetteridge/python312 branch June 20, 2024 13:00
Ig-dolci pushed a commit that referenced this pull request Jul 6, 2024
* Fix cython files for Cython 3.0

* Install with latest numpy

* Update documentation to Python3.9-3.12

---------

Co-authored-by: Connor Ward <c.ward20@imperial.ac.uk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

INSTALL: Firedrake doesn't install on Python 3.12
5 participants