Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove deprecated method. #3398

Merged
merged 4 commits into from
Feb 16, 2024
Merged

Conversation

Ig-dolci
Copy link
Contributor

@Ig-dolci Ig-dolci commented Feb 8, 2024

Description

For ufl.interpolate object, we need to use ufl.domain.extract_unique_domain(self.form) instead of self.form.ufl_domain(). This fix warnings of deprecated self.form.ufl_domain() for ufl.interpolate.

@Ig-dolci Ig-dolci changed the title Avoid the deprecated mehtod for Interpolate remove deprecated method. Feb 9, 2024
@pbrubeck
Copy link
Contributor

Thanks for this @Ig-dolci. My attempt #3259 only left the warnings for the adjoint-related stuff, which I'm not very familiar. Could you also make sure the warning dissapears completely from the tests?

tests/regression/test_adjoint_operators.py: 12 warnings
  /__w/firedrake/firedrake_venv/src/ufl/ufl/core/expr.py:269: DeprecationWarning: Expr.ufl_domain() is deprecated, please use extract_unique_domain(expr) instead.
    warnings.warn("Expr.ufl_domain() is deprecated, please "

@Ig-dolci Ig-dolci marked this pull request as ready for review February 13, 2024 12:12
Copy link
Contributor

@pbrubeck pbrubeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. No more ufl_domain deprecation warnings from adjoint after getting rid of ufl_domain in other parts of this file.

@connorjward connorjward merged commit 503c736 into master Feb 16, 2024
10 checks passed
@connorjward connorjward deleted the dolci/deprecated_ufl_domain_interp branch February 16, 2024 16:42
JDBetteridge pushed a commit that referenced this pull request Mar 5, 2024
---------

Co-authored-by: Pablo Brubeck <brubeck@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants