-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expunge Expr.ufl_domain Part II #3259
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks sensible.
Hurrah, now we are only raising 13414 warnings on CI! This is a massive improvement over the 20947 warnings we generated previously. @pbrubeck do you fancy opening a similar PR to expunge this warning from UFL itself? |
I am not entirely sure we are completely eliminating these warnigns. Maybe I'll first open a ufl PR that fails instead of raising the warning to detect where else we need to change our code, and then open another PR to remove the warning. |
you can either turn warnings into errors in pytest, or, if you run just a python script, do |
We went down to 1249 warnings after making sure this warning is never triggered by the tests. |
28336b1
to
2e70d39
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking the time to do this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just clearing up a strange bit of code. Otherwise fine.
Co-authored-by: Connor Ward <c.ward20@imperial.ac.uk>
Description
This was still triggering warnings at interpolation (and when trying to output non-Lagrange functions).