Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JDBetteridge/petsc priorities #3348
JDBetteridge/petsc priorities #3348
Changes from 29 commits
1b64d0a
0a07708
0cba051
fe2a610
ee6c0c0
b6bd584
2956a05
d7f7dfb
bc1881e
7617992
b990acb
4700fb7
062a966
03a05fb
0cc7b62
b055387
98988f7
abab3de
698a3c6
a871c74
89a935a
0607d3c
b2950ef
7268360
332914c
56249e1
130f0ed
b96785f
0c21e08
758404d
930ed7b
10901dc
2db9c54
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this | (pipe) syntax compatible with python 3.8?
Sorry if it is not the proper place to comment.
Enrico
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Err.... no. Good spot! This is the right place to comment, but unfortunately the code is already merged. I will open a new pull request to remove this.
However, we will very shortly be dropping support for Python 3.8 as Python will soon be dropping support.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, thanks. Actually everything worked fine on 3.9 and 3.10.
Next time, I will try to do the pull request by myself.
Enrico