JDBetteridge/petsc priorities #3348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dham
previously approved these changes
Jan 24, 2024
JDBetteridge
force-pushed
the
JDBetteridge/petsc_priorities
branch
from
ec5af85
to
424f836
Compare
JDBetteridge
changed the base branch from
JDBetteridge/firedrake_lite
to
master
JDBetteridge
changed the title
JDBetteridge
force-pushed
the
JDBetteridge/petsc_priorities
branch
from
6e9510b
to
2293252
Compare
JHopeCollins
reviewed
Feb 1, 2024
JDBetteridge
force-pushed
the
JDBetteridge/petsc_priorities
branch
3 times, most recently
from
10b659b
to
30bfc5a
Compare
dham
previously requested changes
Mar 6, 2024
JDBetteridge
force-pushed
the
JDBetteridge/petsc_priorities
branch
from
30bfc5a
to
fdd4b39
Compare
JDBetteridge
commented
Mar 20, 2024
ksagiyam
reviewed
Apr 3, 2024
JDBetteridge
force-pushed
the
JDBetteridge/petsc_priorities
branch
from
98dbc20
to
89a935a
Compare
JHopeCollins
requested changes
May 14, 2024
JHopeCollins
requested changes
May 14, 2024
Co-authored-by: Josh Hope-Collins <joshua.hope-collins13@imperial.ac.uk>
JDBetteridge
commented
May 15, 2024
JHopeCollins
approved these changes
May 16, 2024
|
I think I'm happy with where things are now. Thanks for doing this Jack, it should make installing different configurations much much easier. |
enricofacca
reviewed
May 21, 2024
|
|
||
| # Looser default tolerance for KSP inside SNES. | ||
| DEFAULT_KSP_PARAMETERS = solving_utils.DEFAULT_KSP_PARAMETERS.copy() | ||
| DEFAULT_KSP_PARAMETERS["ksp_rtol"] = 1e-5 | ||
| DEFAULT_KSP_PARAMETERS = MappingProxyType(DEFAULT_KSP_PARAMETERS | {'ksp_rtol': 1e-5}) |
There was a problem hiding this comment.
Is this | (pipe) syntax compatible with python 3.8?
Sorry if it is not the proper place to comment.
Enrico
There was a problem hiding this comment.
Err.... no. Good spot! This is the right place to comment, but unfortunately the code is already merged. I will open a new pull request to remove this.
However, we will very shortly be dropping support for Python 3.8 as Python will soon be dropping support.
There was a problem hiding this comment.
Ok, thanks. Actually everything worked fine on 3.9 and 3.10.
Next time, I will try to do the pull request by myself.
Enrico
Ig-dolci
pushed a commit
that referenced
this pull request
Jul 6, 2024
* Move all PETSc defaults to petsc.py * Add warnings when defaulting to PETSc internals * Stop installing Chaco by default * Remove Chaco and ML from docker container --------- Co-authored-by: David A. Ham <david.ham@imperial.ac.uk> Co-authored-by: Josh Hope-Collins <joshua.hope-collins13@imperial.ac.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Internal refactor of how we set PETSc defaults. This is now based off which PETSc external packages are installed. Now a user with an external PETSc with only:
should expect the Firedrake test suite to pass.
Moving forward tests that use optional dependencies, such as:
Should check for the presence of the optional dependency before being included in the Firedrake test suite.