-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JDBetteridge/petsc priorities #3348
Conversation
ec5af85
to
424f836
Compare
6e9510b
to
2293252
Compare
10b659b
to
30bfc5a
Compare
30bfc5a
to
fdd4b39
Compare
98dbc20
to
89a935a
Compare
Co-authored-by: Josh Hope-Collins <joshua.hope-collins13@imperial.ac.uk>
I think I'm happy with where things are now. Thanks for doing this Jack, it should make installing different configurations much much easier. |
|
||
# Looser default tolerance for KSP inside SNES. | ||
DEFAULT_KSP_PARAMETERS = solving_utils.DEFAULT_KSP_PARAMETERS.copy() | ||
DEFAULT_KSP_PARAMETERS["ksp_rtol"] = 1e-5 | ||
DEFAULT_KSP_PARAMETERS = MappingProxyType(DEFAULT_KSP_PARAMETERS | {'ksp_rtol': 1e-5}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this | (pipe) syntax compatible with python 3.8?
Sorry if it is not the proper place to comment.
Enrico
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Err.... no. Good spot! This is the right place to comment, but unfortunately the code is already merged. I will open a new pull request to remove this.
However, we will very shortly be dropping support for Python 3.8 as Python will soon be dropping support.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, thanks. Actually everything worked fine on 3.9 and 3.10.
Next time, I will try to do the pull request by myself.
Enrico
* Move all PETSc defaults to petsc.py * Add warnings when defaulting to PETSc internals * Stop installing Chaco by default * Remove Chaco and ML from docker container --------- Co-authored-by: David A. Ham <david.ham@imperial.ac.uk> Co-authored-by: Josh Hope-Collins <joshua.hope-collins13@imperial.ac.uk>
Description
Internal refactor of how we set PETSc defaults. This is now based off which PETSc external packages are installed. Now a user with an external PETSc with only:
should expect the Firedrake test suite to pass.
Moving forward tests that use optional dependencies, such as:
Should check for the presence of the optional dependency before being included in the Firedrake test suite.