Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add methods for getting L1 distance of a point from reference cells #33

Merged
merged 18 commits into from
Feb 15, 2023
Merged

Add methods for getting L1 distance of a point from reference cells #33

merged 18 commits into from
Feb 15, 2023

Commits on Jan 25, 2023

  1. add tests to contains point

    @ReubenHill
    ReubenHill committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    8ce5230 View commit details
    Browse the repository at this point in the history

  2. add new distance_to_point method to UFCSimplex and use in contains_point

    @ReubenHill
    ReubenHill committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    4787229 View commit details
    Browse the repository at this point in the history

  3. Test distance_to_point for all reference elements 

    Note that tensor product doesn't work yet
    @ReubenHill
    ReubenHill committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    ccc748a View commit details
    Browse the repository at this point in the history

  4. make sure we get 0.0 distance on cell boundary

    @ReubenHill
    ReubenHill committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    82a44e9 View commit details
    Browse the repository at this point in the history

  5. distance_to_point for UFCQuadrilateral

    @ReubenHill
    ReubenHill committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    000660d View commit details
    Browse the repository at this point in the history

  6. Raise notimplemented for TensorProductCell distance_to_point

    @ReubenHill
    ReubenHill committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    d56de55 View commit details
    Browse the repository at this point in the history

  7. restore old contains_point for sympy 

    In firedrake contains_point has sympy arguments given to it and I can't
think of a way to make it work with distance_to_point since you have to
actually do the computation to get the distance. Maybe there's a way to
force sympy to play nice? The error I get is
TypeError: cannot determine truth value of Relational
    @ReubenHill
    ReubenHill committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    4aa7634 View commit details
    Browse the repository at this point in the history

  8. Fix docstring mistakes

    @ReubenHill
    ReubenHill committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    0355d87 View commit details
    Browse the repository at this point in the history

  9. Change logic to work with sympy 

    By changing the logic slightly we avoid needing to use min and the
code ought to work with sympy.
    @ReubenHill
    ReubenHill committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    c55d7b9 View commit details
    Browse the repository at this point in the history

Commits on Jan 26, 2023

  1. make clear we are using L1 distance

    @ReubenHill
    ReubenHill committed Jan 26, 2023
    Configuration menu
    Copy the full SHA
    4fa31bf View commit details
    Browse the repository at this point in the history

  2. update tests for giving L1 distance

    @ReubenHill
    ReubenHill committed Jan 26, 2023
    Configuration menu
    Copy the full SHA
    0595154 View commit details
    Browse the repository at this point in the history

Commits on Jan 27, 2023

  1. distance_to_point_l1 for TensorProductCell

    @ReubenHill
    ReubenHill committed Jan 27, 2023
    Configuration menu
    Copy the full SHA
    8994190 View commit details
    Browse the repository at this point in the history

  2. fix tests since we now use l1 distance

    @ReubenHill
    ReubenHill committed Jan 27, 2023
    Configuration menu
    Copy the full SHA
    b59f969 View commit details
    Browse the repository at this point in the history

  3. change contains_point docstring everywhere

    @ReubenHill
    ReubenHill committed Jan 27, 2023
    Configuration menu
    Copy the full SHA
    aaf1b46 View commit details
    Browse the repository at this point in the history

  4. make contains_point for TensorProductCell clearer

    @ReubenHill
    ReubenHill committed Jan 27, 2023
    Configuration menu
    Copy the full SHA
    d9ce3a8 View commit details
    Browse the repository at this point in the history

  5. lint docstrings

    @ReubenHill
    ReubenHill committed Jan 27, 2023
    Configuration menu
    Copy the full SHA
    35bb9f2 View commit details
    Browse the repository at this point in the history

Commits on Feb 6, 2023

  1. Add distance_to_point_l1 to UFCHexahedron

    @ReubenHill
    ReubenHill committed Feb 6, 2023
    Configuration menu
    Copy the full SHA
    4ca094e View commit details
    Browse the repository at this point in the history

Commits on Feb 8, 2023

  1. improve distance_to_point_l1 comment

    @ReubenHill
    ReubenHill committed Feb 8, 2023
    Configuration menu
    Copy the full SHA
    7eb4bf5 View commit details
    Browse the repository at this point in the history