Add methods for getting L1 distance of a point from reference cells #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ReubenHill
force-pushed
the
ReubenHill/point-locate
branch
from
344e01b
to
322991e
Compare
Note that tensor product doesn't work yet
In firedrake contains_point has sympy arguments given to it and I can't think of a way to make it work with distance_to_point since you have to actually do the computation to get the distance. Maybe there's a way to force sympy to play nice? The error I get is TypeError: cannot determine truth value of Relational
By changing the logic slightly we avoid needing to use min and the code ought to work with sympy.
ReubenHill
force-pushed
the
ReubenHill/point-locate
branch
from
322991e
to
c55d7b9
Compare
ReubenHill
commented
Feb 6, 2023
ReubenHill
changed the title
dham
approved these changes
Feb 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For use see firedrakeproject/firedrake#2662