Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changelog for 4261 and 4242 #4272

Merged
merged 3 commits into from
Nov 27, 2023
Merged

Conversation

roypat
Copy link
Contributor

@roypat roypat commented Nov 24, 2023

Forgot the entry in #4261

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following
Developer Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.

PR Checklist

  • If a specific issue led to this PR, this PR closes the issue.
  • The description of changes is clear and encompassing.
  • Any required documentation changes (code and docs) are included in this PR.
  • API changes follow the Runbook for Firecracker API changes.
  • User-facing changes are mentioned in CHANGELOG.md.
  • All added/changed functionality is tested.
  • New TODOs link to an issue.
  • Commits meet contribution quality standards.

  • This functionality cannot be added in rust-vmm.

@roypat roypat added the Status: Awaiting review Indicates that a pull request is ready to be reviewed label Nov 24, 2023
CHANGELOG.md Outdated Show resolved Hide resolved
Copy link

codecov bot commented Nov 24, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b1c52ca) 81.69% compared to head (2af4eb2) 77.15%.

❗ Current head 2af4eb2 differs from pull request most recent head 37f769b. Consider uploading reports for the commit 37f769b to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4272      +/-   ##
==========================================
- Coverage   81.69%   77.15%   -4.55%     
==========================================
  Files         240      212      -28     
  Lines       29292    24869    -4423     
==========================================
- Hits        23931    19187    -4744     
- Misses       5361     5682     +321     
Flag Coverage Δ
4.14-c7g.metal 77.15% <ø> (-0.01%) ⬇️
4.14-m5d.metal ?
4.14-m6a.metal ?
4.14-m6g.metal ?
4.14-m6i.metal ?
5.10-c7g.metal ?
5.10-m5d.metal ?
5.10-m6a.metal ?
5.10-m6g.metal ?
5.10-m6i.metal ?
6.1-c7g.metal ?
6.1-m5d.metal ?
6.1-m6a.metal ?
6.1-m6g.metal ?
6.1-m6i.metal ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wearyzen wearyzen changed the title Changelog for 4261 Changelog for 4261 and 4242 Nov 24, 2023
It is technically a bug fix

Signed-off-by: Patrick Roy <roypat@amazon.co.uk>
It was the only entry where the PR link was missing.

Signed-off-by: Patrick Roy <roypat@amazon.co.uk>
It was forgotten about in that PR.

Signed-off-by: Patrick Roy <roypat@amazon.co.uk>
@roypat roypat merged commit 2d5a705 into firecracker-microvm:main Nov 27, 2023
5 checks passed
@roypat roypat deleted the changelog-for-4261 branch April 15, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Awaiting review Indicates that a pull request is ready to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants