fix: Support all logger level case variants #4242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonathanWoollett-Light
force-pushed
the
logger-level-string
branch
from
87a10b3
to
20baf0c
Compare
JonathanWoollett-Light
changed the title
JonathanWoollett-Light
force-pushed
the
logger-level-string
branch
2 times, most recently
from
3aeda6c
to
a208275
Compare
wearyzen
force-pushed
the
logger-level-string
branch
from
2887ed3
to
b1c6c75
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #4242 +/- ##
=======================================
Coverage 81.66% 81.66%
=======================================
Files 240 240
Lines 29288 29303 +15
=======================================
+ Hits 23917 23931 +14
- Misses 5371 5372 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
wearyzen
force-pushed
the
logger-level-string
branch
3 times, most recently
from
a83930f
to
9e7af0a
Compare
wearyzen
force-pushed
the
logger-level-string
branch
7 times, most recently
from
feb4256
to
68f56ff
Compare
wearyzen
added
the
Status: Awaiting review
roypat
reviewed
Nov 24, 2023
wearyzen
force-pushed
the
logger-level-string
branch
4 times, most recently
from
f84e334
to
ce3deeb
Compare
wearyzen
force-pushed
the
logger-level-string
branch
from
ce3deeb
to
dce6bfc
Compare
pb8o
reviewed
Nov 24, 2023
wearyzen
force-pushed
the
logger-level-string
branch
from
dce6bfc
to
fb9997c
Compare
wearyzen
force-pushed
the
logger-level-string
branch
2 times, most recently
from
3ccead7
to
31b1a03
Compare
roypat
reviewed
Nov 24, 2023
wearyzen
force-pushed
the
logger-level-string
branch
4 times, most recently
from
012138a
to
0fb909c
Compare
roypat
previously approved these changes
Nov 24, 2023
wearyzen
force-pushed
the
logger-level-string
branch
2 times, most recently
from
a875a93
to
97f528d
Compare
firecracker-microvm#4047 updated parsing the logger level filter. It removed all case variants outside fully uppercase (e.g. `INFO`) and the 1st character being upper case (e.g. `Info`) this removed support for other previously supported variants e.g. `info`. This commit re-introduces this support such that all variants should again be supported. Fixes commit 332f218 Signed-off-by: Jonathan Woollett-Light <jcawl@amazon.co.uk> Signed-off-by: Sudan Landge <sudanl@amazon.com>
Add unit test to cover all cases of LevelFilter. Remove redundant logic from levelfilter_from_str because levelfilter_from_str_all_variants is a better place to put the logic. Signed-off-by: Jonathan Woollett-Light <jcawl@amazon.co.uk> Signed-off-by: Sudan Landge <sudanl@amazon.com>
wearyzen
force-pushed
the
logger-level-string
branch
from
97f528d
to
08ae0d9
Compare
roypat
approved these changes
Nov 24, 2023
pb8o
approved these changes
Nov 24, 2023
6 tasks
roypat
added a commit
to roypat/firecracker
that referenced
this pull request
Nov 24, 2023
It was forgotten about in that PR. Signed-off-by: Patrick Roy <roypat@amazon.co.uk>
roypat
added a commit
to roypat/firecracker
that referenced
this pull request
Nov 24, 2023
It was forgotten about in that PR. Signed-off-by: Patrick Roy <roypat@amazon.co.uk>
roypat
added a commit
to roypat/firecracker
that referenced
this pull request
Nov 24, 2023
It was forgotten about in that PR. Signed-off-by: Patrick Roy <roypat@amazon.co.uk>
wearyzen
pushed a commit
to roypat/firecracker
that referenced
this pull request
Nov 27, 2023
It was forgotten about in that PR. Signed-off-by: Patrick Roy <roypat@amazon.co.uk>
roypat
added a commit
that referenced
this pull request
Nov 27, 2023
It was forgotten about in that PR. Signed-off-by: Patrick Roy <roypat@amazon.co.uk>
roypat
added a commit
to roypat/firecracker
that referenced
this pull request
Nov 27, 2023
It was forgotten about in that PR. Signed-off-by: Patrick Roy <roypat@amazon.co.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This commit re-introduces this support such that all variants should again be supported.
Reason
#4047 updated
parsing the logger level filter. It removed all case variants outside
fully uppercase (e.g.
INFO) and the 1st character being upper case(e.g.
Info) this removed support for other previously supportedvariants e.g.
info.License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following
Developer Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
[ ] Any required documentation changes (code and docs) are included in this PR.[ ] API changes follow the Runbook for Firecracker API changes.[ ] User-facing changes are mentioned inCHANGELOG.md.[ ] NewTODOs link to an issue.rust-vmm.