-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update logger #4047
Merged
JonathanWoollett-Light
merged 7 commits into
firecracker-microvm:main
from
JonathanWoollett-Light:update_logger
Oct 6, 2023
Merged
Update logger #4047
JonathanWoollett-Light
merged 7 commits into
firecracker-microvm:main
from
JonathanWoollett-Light:update_logger
Oct 6, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #4047 +/- ##
==========================================
- Coverage 83.10% 82.97% -0.13%
==========================================
Files 225 223 -2
Lines 28605 28452 -153
==========================================
- Hits 23772 23609 -163
- Misses 4833 4843 +10
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
JonathanWoollett-Light
force-pushed
the
update_logger
branch
28 times, most recently
from
August 23, 2023 12:15
d033858
to
507cb99
Compare
Runs updated `cargo fmt`. Signed-off-by: Jonathan Woollett-Light <jcawl@amazon.co.uk>
Re-exports logging macros from `logger` to allow more atomic changes in `logger`. Signed-off-by: Jonathan Woollett-Light <jcawl@amazon.co.uk>
- Refactors the logger implementation, simplifying the implementation and reducing the binary size by ~20kb. - Adds support for runtime reconfiguration. - Updates the check for the `Running Firecracker` log to match. - Updates the default log level to `Info`. Signed-off-by: Jonathan Woollett-Light <jcawl@amazon.co.uk>
Adds a logger initialization function that allows removing the `log` dependencies. Signed-off-by: Jonathan Woollett-Light <jcawl@amazon.co.uk>
Moves argument passing before logging `Running Firecracker` and other code that may not be required if certain arguments are passed causing the process to exit early. Signed-off-by: Jonathan Woollett-Light <jcawl@amazon.co.uk>
JonathanWoollett-Light
force-pushed
the
update_logger
branch
from
October 6, 2023 09:49
d0e7b52
to
1228116
Compare
roypat
approved these changes
Oct 6, 2023
JonathanWoollett-Light
merged commit Oct 6, 2023
fa4b299
into
firecracker-microvm:main
5 of 7 checks passed
JonathanWoollett-Light
pushed a commit
to JonathanWoollett-Light/firecracker
that referenced
this pull request
Nov 15, 2023
firecracker-microvm#4047 updated parsing the logger level filter. It removed all case variants outside fully uppercase (e.g. `INFO`) and the 1st character being upper case (e.g. `Info`) this removed support for other previously supported variants e.g. `info`. This commit re-introduces this support such that all variants should again be supported. Signed-off-by: Jonathan Woollett-Light <jcawl@amazon.co.uk>
5 tasks
JonathanWoollett-Light
pushed a commit
to JonathanWoollett-Light/firecracker
that referenced
this pull request
Nov 15, 2023
firecracker-microvm#4047 updated parsing the logger level filter. It removed all case variants outside fully uppercase (e.g. `INFO`) and the 1st character being upper case (e.g. `Info`) this removed support for other previously supported variants e.g. `info`. This commit re-introduces this support such that all variants should again be supported. Signed-off-by: Jonathan Woollett-Light <jcawl@amazon.co.uk>
wearyzen
pushed a commit
to JonathanWoollett-Light/firecracker
that referenced
this pull request
Nov 23, 2023
firecracker-microvm#4047 updated parsing the logger level filter. It removed all case variants outside fully uppercase (e.g. `INFO`) and the 1st character being upper case (e.g. `Info`) this removed support for other previously supported variants e.g. `info`. This commit re-introduces this support such that all variants should again be supported. Signed-off-by: Jonathan Woollett-Light <jcawl@amazon.co.uk> Signed-off-by: Sudan Landge <sudanl@amazon.com>
wearyzen
pushed a commit
to JonathanWoollett-Light/firecracker
that referenced
this pull request
Nov 23, 2023
firecracker-microvm#4047 updated parsing the logger level filter. It removed all case variants outside fully uppercase (e.g. `INFO`) and the 1st character being upper case (e.g. `Info`) this removed support for other previously supported variants e.g. `info`. This commit re-introduces this support such that all variants should again be supported. Signed-off-by: Jonathan Woollett-Light <jcawl@amazon.co.uk> Signed-off-by: Sudan Landge <sudanl@amazon.com>
wearyzen
pushed a commit
to JonathanWoollett-Light/firecracker
that referenced
this pull request
Nov 23, 2023
firecracker-microvm#4047 updated parsing the logger level filter. It removed all case variants outside fully uppercase (e.g. `INFO`) and the 1st character being upper case (e.g. `Info`) this removed support for other previously supported variants e.g. `info`. This commit re-introduces this support such that all variants should again be supported. Signed-off-by: Jonathan Woollett-Light <jcawl@amazon.co.uk> Signed-off-by: Sudan Landge <sudanl@amazon.com>
wearyzen
pushed a commit
to JonathanWoollett-Light/firecracker
that referenced
this pull request
Nov 24, 2023
firecracker-microvm#4047 updated parsing the logger level filter. It removed all case variants outside fully uppercase (e.g. `INFO`) and the 1st character being upper case (e.g. `Info`) this removed support for other previously supported variants e.g. `info`. This commit re-introduces this support such that all variants should again be supported. Signed-off-by: Jonathan Woollett-Light <jcawl@amazon.co.uk> Signed-off-by: Sudan Landge <sudanl@amazon.com>
wearyzen
pushed a commit
to JonathanWoollett-Light/firecracker
that referenced
this pull request
Nov 24, 2023
firecracker-microvm#4047 updated parsing the logger level filter. It removed all case variants outside fully uppercase (e.g. `INFO`) and the 1st character being upper case (e.g. `Info`) this removed support for other previously supported variants e.g. `info`. This commit re-introduces this support such that all variants should again be supported. Signed-off-by: Jonathan Woollett-Light <jcawl@amazon.co.uk> Signed-off-by: Sudan Landge <sudanl@amazon.com>
wearyzen
pushed a commit
to JonathanWoollett-Light/firecracker
that referenced
this pull request
Nov 24, 2023
firecracker-microvm#4047 updated parsing the logger level filter. It removed all case variants outside fully uppercase (e.g. `INFO`) and the 1st character being upper case (e.g. `Info`) this removed support for other previously supported variants e.g. `info`. This commit re-introduces this support such that all variants should again be supported. Signed-off-by: Jonathan Woollett-Light <jcawl@amazon.co.uk> Signed-off-by: Sudan Landge <sudanl@amazon.com>
wearyzen
pushed a commit
to JonathanWoollett-Light/firecracker
that referenced
this pull request
Nov 24, 2023
firecracker-microvm#4047 updated parsing the logger level filter. It removed all case variants outside fully uppercase (e.g. `INFO`) and the 1st character being upper case (e.g. `Info`) this removed support for other previously supported variants e.g. `info`. This commit re-introduces this support such that all variants should again be supported. Fixes firecracker-microvm@332f218 Signed-off-by: Jonathan Woollett-Light <jcawl@amazon.co.uk> Signed-off-by: Sudan Landge <sudanl@amazon.com>
wearyzen
pushed a commit
to JonathanWoollett-Light/firecracker
that referenced
this pull request
Nov 24, 2023
firecracker-microvm#4047 updated parsing the logger level filter. It removed all case variants outside fully uppercase (e.g. `INFO`) and the 1st character being upper case (e.g. `Info`) this removed support for other previously supported variants e.g. `info`. This commit re-introduces this support such that all variants should again be supported. Fixes #332f2184ae29265fbae1648469e073fc7f987378 Signed-off-by: Jonathan Woollett-Light <jcawl@amazon.co.uk> Signed-off-by: Sudan Landge <sudanl@amazon.com>
wearyzen
pushed a commit
to JonathanWoollett-Light/firecracker
that referenced
this pull request
Nov 24, 2023
firecracker-microvm#4047 updated parsing the logger level filter. It removed all case variants outside fully uppercase (e.g. `INFO`) and the 1st character being upper case (e.g. `Info`) this removed support for other previously supported variants e.g. `info`. This commit re-introduces this support such that all variants should again be supported. Fixes commit 332f218 Signed-off-by: Jonathan Woollett-Light <jcawl@amazon.co.uk> Signed-off-by: Sudan Landge <sudanl@amazon.com>
wearyzen
pushed a commit
to JonathanWoollett-Light/firecracker
that referenced
this pull request
Nov 24, 2023
firecracker-microvm#4047 updated parsing the logger level filter. It removed all case variants outside fully uppercase (e.g. `INFO`) and the 1st character being upper case (e.g. `Info`) this removed support for other previously supported variants e.g. `info`. This commit re-introduces this support such that all variants should again be supported. Fixes commit 332f218 Signed-off-by: Jonathan Woollett-Light <jcawl@amazon.co.uk> Signed-off-by: Sudan Landge <sudanl@amazon.com>
wearyzen
pushed a commit
to JonathanWoollett-Light/firecracker
that referenced
this pull request
Nov 24, 2023
firecracker-microvm#4047 updated parsing the logger level filter. It removed all case variants outside fully uppercase (e.g. `INFO`) and the 1st character being upper case (e.g. `Info`) this removed support for other previously supported variants e.g. `info`. This commit re-introduces this support such that all variants should again be supported. Fixes commit 332f218 Signed-off-by: Jonathan Woollett-Light <jcawl@amazon.co.uk> Signed-off-by: Sudan Landge <sudanl@amazon.com>
wearyzen
pushed a commit
to JonathanWoollett-Light/firecracker
that referenced
this pull request
Nov 24, 2023
firecracker-microvm#4047 updated parsing the logger level filter. It removed all case variants outside fully uppercase (e.g. `INFO`) and the 1st character being upper case (e.g. `Info`) this removed support for other previously supported variants e.g. `info`. This commit re-introduces this support such that all variants should again be supported. Fixes commit 332f218 Signed-off-by: Jonathan Woollett-Light <jcawl@amazon.co.uk> Signed-off-by: Sudan Landge <sudanl@amazon.com>
wearyzen
pushed a commit
that referenced
this pull request
Nov 24, 2023
#4047 updated parsing the logger level filter. It removed all case variants outside fully uppercase (e.g. `INFO`) and the 1st character being upper case (e.g. `Info`) this removed support for other previously supported variants e.g. `info`. This commit re-introduces this support such that all variants should again be supported. Fixes commit 332f218 Signed-off-by: Jonathan Woollett-Light <jcawl@amazon.co.uk> Signed-off-by: Sudan Landge <sudanl@amazon.com>
6 tasks
wearyzen
pushed a commit
that referenced
this pull request
Nov 27, 2023
#4047 updated parsing the logger level filter. It removed all case variants outside fully uppercase (e.g. `INFO`) and the 1st character being upper case (e.g. `Info`) this removed support for other previously supported variants e.g. `info`. This commit re-introduces this support such that all variants should again be supported. Fixes commit 332f218 Signed-off-by: Jonathan Woollett-Light <jcawl@amazon.co.uk> Signed-off-by: Sudan Landge <sudanl@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
2681136
->2664816
).Reason
See above.
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following
Developer Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md
.PR Checklist
CHANGELOG.md
.TODO
s link to an issue.rust-vmm
.