Skip to content

fix(auth, web): correct use of underlying useEmulator API, sync not async #5171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 8, 2021
Merged

fix(auth, web): correct use of underlying useEmulator API, sync not async #5171

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/firebase_auth/firebase_auth_web/lib/firebase_auth_web.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -348,7 +348,7 @@ class FirebaseAuthWeb extends FirebaseAuthPlatform {
// The generic platform interface is with host and port split to
// centralize logic between android/ios native, but web takes the
// origin as a single string
await _webAuth!.useEmulator('http://$host:$port');
_webAuth!.useEmulator('http://$host:$port');
} catch (e) {
throw getFirebaseAuthException(e);
}
Expand Down
3 changes: 1 addition & 2 deletions packages/firebase_auth/firebase_auth_web/lib/src/interop/auth.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -615,8 +615,7 @@ class Auth extends JsObjectWrapper<auth_interop.AuthJsImpl> {
///
/// Note: must be called before using auth methods, do not use
/// with production credentials as local connections are unencrypted
Future useEmulator(String origin) =>
handleThenable(jsObject.useEmulator(origin));
void useEmulator(String origin) => jsObject.useEmulator(origin);

/// Sets the current language to the default device/browser preference.
void useDeviceLanguage() => jsObject.useDeviceLanguage();
Expand Down