fix(auth, web): correct use of underlying useEmulator API, sync not async #5171
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
My original implementation of auth.useEmulator for FlutterFire in #4263 used the underlying firebase-js-sdk incorrectly for the web implementation
Underlying web API for useEmulator is sync not async, so attempting to await it and call .then resulted in an error since no Promise was returned.
Supporting auth.useEmulator officially should still require the Firestore issue uncovered in firebase-js-sdk >= v8.0.1 to be resolved, tracked here #4127 - but if users are willing to pin firebase-js-sdk === v8.0.1 auth.useEmulator will now work for them and firebase web in general should work
For people testing this and using firestore on web: firebase-js-sdk v8.0.1 is reported to work with auth.useEmulator without triggering the problem described in #4127 - thanks to @wtfiwtz for success report
Related Issues
Fixes #5096
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]
).This will ensure a smooth and quick review process. Updating the
pubspec.yaml
and changelogs is not required.///
).flutter analyze
) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?