Skip to content

chore: mockito dependency updates, dependency changes & analysis warnings/errors #5014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Feb 15, 2021

Conversation

russellwheatley
Copy link
Member

@russellwheatley russellwheatley commented Feb 11, 2021

Description

This PR affects auth, core, messaging database & firestore packages.

  • mockito dependency breaks the all_plugins/tests check for github actions. It made a breaking change to the API which this PR resolves.
  • removed UUID dependency in auth_example.
  • changed js dependency version to be less restrictive in storage_web: js: ^0.6.3-nullsafety.3 (i.e. uses caret syntax).
  • removed deprecated BinaryMessages API and replaced with ServicesBinding.instance.defaultBinaryMessenger as recommended here.
  • commented out runTransaction test as it was failing. Needs further investigation. Test fixed.

Related Issues

Replace this paragraph with a list of issues related to this PR from the issue database. Indicate, which of these issues are resolved or fixed by this PR. Note that you'll have to prefix the issue numbers with flutter/flutter#.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@russellwheatley russellwheatley changed the title chore: mockito dependency updates & dependency changes for Melos chore: mockito dependency updates, dependency changes & analysis warnings/errors Feb 11, 2021
@Salakar Salakar merged commit 0486583 into @ehesp/storage-nndb Feb 15, 2021
@Salakar Salakar deleted the @russell/mockito-andd-dependency-fixes branch February 15, 2021 10:34
@firebase firebase locked and limited conversation to collaborators Mar 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants