Skip to content

fix: Bump mockito to breaking change with fixes #4942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

srawlins
Copy link

@srawlins srawlins commented Feb 3, 2021

Description

mockito 5.0.0-nullsafety.6 includes a breaking change to the signature of Mock.noSuchMethod. This PR bump mockito and changes firebase_auth and firebase_core tests to match the new signature.

Related Issues

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@google-cla google-cla bot added the cla: yes label Feb 3, 2021
@srawlins srawlins changed the title Bump mockito to breaking change with fixes fix: Bump mockito to breaking change with fixes Feb 3, 2021
@srawlins
Copy link
Author

srawlins commented Feb 8, 2021

Not sure what to do about the current CI errors. Does it have to do with Flutter test version pinning?

@russellwheatley
Copy link
Member

Hey @srawlins, thanks for the PR! Mockito upgrades were merged in this here:#5014 so I'm going to close this one 👍

@firebase firebase locked and limited conversation to collaborators Mar 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants