refactor(functions): migrate to nnbd #4691
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Salakar
force-pushed
the
@Salakar/functions-nnbd
branch
from
a4b9bfd to
1b4ce89
Compare
Salakar
force-pushed
the
@Salakar/functions-nnbd
branch
from
1b4ce89 to
ddd8e0d
Compare
Salakar
commented
Jan 16, 2021
...nctions_platform_interface/lib/src/platform_interface/platform_interface_https_callable.dart
Show resolved
Hide resolved
… the default MethodChannel instance is used
…ve coverage and remove mockito usage
…packages in example app
rrousselGit
reviewed
Jan 19, 2021
| @@ -0,0 +1,184 @@ | |||
| # Copyright 2021 The Chromium Authors. All rights reserved. | |||
There was a problem hiding this comment.
We could probably move the one in firebase_core above /packages and reuse it here to avoid duplicates
There was a problem hiding this comment.
Might be worth getting the individual PRs merged in then doing that since there's a number ongoing at once?
There was a problem hiding this comment.
In favour of doing this at the end after we've migrated the others, or on a separate PR, wanted to keep this PR self contained to cloud functions changes only.
Tracking internally on INVERTASE/FF-16.
rrousselGit
reviewed
Jan 19, 2021
rrousselGit
reviewed
Jan 19, 2021
rrousselGit
reviewed
Jan 19, 2021
packages/cloud_functions/cloud_functions/lib/src/https_callable_result.dart
Outdated
Show resolved
Hide resolved
rrousselGit
reviewed
Jan 19, 2021
packages/cloud_functions/cloud_functions/test/firebase_functions_test.dart
Outdated
Show resolved
Hide resolved
rrousselGit
reviewed
Jan 19, 2021
packages/cloud_functions/cloud_functions/test/firebase_functions_test.dart
Outdated
Show resolved
Hide resolved
rrousselGit
reviewed
Jan 19, 2021
...cloud_functions_platform_interface/lib/src/method_channel/method_channel_https_callable.dart
Outdated
Show resolved
Hide resolved
rrousselGit
reviewed
Jan 19, 2021
packages/cloud_functions/cloud_functions_web/test/cloud_functions_web_test.dart
Outdated
Show resolved
Hide resolved
rrousselGit
reviewed
Jan 19, 2021
packages/cloud_functions/cloud_functions_web/lib/interop/functions.dart
Outdated
Show resolved
Hide resolved
Ehesp
reviewed
Jan 19, 2021
...ons_platform_interface/lib/src/platform_interface/platform_interface_firebase_functions.dart
Show resolved
Hide resolved
Salakar
force-pushed
the
@Salakar/functions-nnbd
branch
from
032f5b4 to
9364216
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Migrate Firebase Functions packages to NNBD.
Related Issues
Replace this paragraph with a list of issues related to this PR from the issue database. Indicate, which of these issues are resolved or fixed by this PR. Note that you'll have to prefix the issue numbers with flutter/flutter#.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]).This will ensure a smooth and quick review process. Updating the
pubspec.yamland changelogs is not required.///).flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?