style(functions): fix issues highlighted by new lint rules

Author: Salakar

packages/cloud_functions/cloud_functions/example/lib/main.dart

@@ -21,6 +21,8 @@ Future<void> main() async {
 
 // ignore: public_member_api_docs
 class MyApp extends StatefulWidget {
+  // ignore: public_member_api_docs
+  MyApp({Key key}) : super(key: key);
   @override
   _MyAppState createState() => _MyAppState();
 }
@@ -45,7 +47,7 @@ class _MyAppState extends State<MyApp> {
                 itemCount: fruit.length,
                 itemBuilder: (context, index) {
                   return ListTile(
-                    title: Text("${fruit[index]}"),
+                    title: Text('${fruit[index]}'),
                   );
                 })),
         floatingActionButton: Builder(
@@ -55,7 +57,8 @@ class _MyAppState extends State<MyApp> {
               // are using for this example
               HttpsCallable callable = FirebaseFunctions.instance.httpsCallable(
                   'listFruit',
-                  options: HttpsCallableOptions(timeout: Duration(seconds: 5)));
+                  options: HttpsCallableOptions(
+                      timeout: const Duration(seconds: 5)));
 
               await callable().then((v) {
                 setState(() {
@@ -66,12 +69,12 @@ class _MyAppState extends State<MyApp> {
                 });
               }).catchError((e) {
                 ScaffoldMessenger.of(context).showSnackBar(SnackBar(
-                  content: Text("ERROR: $e"),
+                  content: Text('ERROR: $e'),
                 ));
               });
             },
-            label: Text('Call Function'),
-            icon: Icon(Icons.cloud),
+            label: const Text('Call Function'),
+            icon: const Icon(Icons.cloud),
             backgroundColor: Colors.deepOrange,
           ),
         ),

packages/cloud_functions/cloud_functions/example/test_driver/cloud_functions_e2e.dart

@@ -140,13 +140,13 @@ void testsMain() {
     setUpAll(() async {
       timeoutCallable = FirebaseFunctions.instance.httpsCallable(
           kTestFunctionTimeout,
-          options: HttpsCallableOptions(timeout: Duration(seconds: 3)));
+          options: HttpsCallableOptions(timeout: const Duration(seconds: 3)));
     });
 
     test('times out when the provided timeout is exceeded', () async {
       try {
         await timeoutCallable({
-          'testTimeout': Duration(seconds: 6).inMilliseconds.toString(),
+          'testTimeout': const Duration(seconds: 6).inMilliseconds.toString(),
         });
         fail('Should have thrown');
       } on FirebaseFunctionsException catch (e) {

packages/cloud_functions/cloud_functions/lib/src/firebase_functions.dart

@@ -10,26 +10,23 @@ part of cloud_functions;
 ///
 /// You can get an instance by calling [FirebaseFunctions.instance].
 class FirebaseFunctions extends FirebasePluginPlatform {
+  FirebaseFunctions._({this.app, String region})
+      : _region = region ??= 'us-central1',
+        super(app.name, 'plugins.flutter.io/firebase_functions');
+
   // Cached and lazily loaded instance of [FirebaseFunctionsPlatform] to avoid
   // creating a [MethodChannelFirebaseFunctions] when not needed or creating an
   // instance with the default app before a user specifies an app.
   FirebaseFunctionsPlatform _delegatePackingProperty;
 
   FirebaseFunctionsPlatform get _delegate {
-    if (_delegatePackingProperty == null) {
-      _delegatePackingProperty =
-          FirebaseFunctionsPlatform.instanceFor(app: app, region: _region);
-    }
-    return _delegatePackingProperty;
+    return _delegatePackingProperty ??=
+        FirebaseFunctionsPlatform.instanceFor(app: app, region: _region);
   }
 
   /// The [FirebaseApp] for this current [FirebaseFunctions] instance.
   final FirebaseApp app;
 
-  FirebaseFunctions._({this.app, String region})
-      : _region = region ??= 'us-central1',
-        super(app.name, 'plugins.flutter.io/firebase_functions');
-
   static final Map<String, FirebaseFunctions> _cachedInstances = {};
 
   /// Returns an instance using the default [FirebaseApp] and region.
@@ -79,9 +76,12 @@ class FirebaseFunctions extends FirebasePluginPlatform {
       // Android considers localhost as 10.0.2.2 - automatically handle this for users.
       if (defaultTargetPlatform == TargetPlatform.android) {
         if (origin.startsWith('http://localhost')) {
-          origin = origin.replaceFirst('http://localhost', 'http://10.0.2.2');
-        } else if (origin.startsWith('http://127.0.0.1')) {
-          origin = origin.replaceFirst('http://127.0.0.1', 'http://10.0.2.2');
+          _origin = origin.replaceFirst('http://localhost', 'http://10.0.2.2');
+          return;
+        }
+        if (origin.startsWith('http://127.0.0.1')) {
+          _origin = origin.replaceFirst('http://127.0.0.1', 'http://10.0.2.2');
+          return;
         }
       }
     }

packages/cloud_functions/cloud_functions/lib/src/https_callable.dart

@@ -38,8 +38,9 @@ class HttpsCallable {
 /// Asserts whether a given call parameter is a valid type.
 void _assertValidParameterType(dynamic parameter, [bool isRoot = true]) {
   if (parameter is List) {
-    return parameter
-        .forEach((element) => _assertValidParameterType(element, false));
+    for (final element in parameter) {
+      _assertValidParameterType(element, false);
+    }
   }
 
   if (parameter is Map) {

packages/cloud_functions/cloud_functions/test/firebase_functions_test.dart

@@ -8,11 +8,10 @@ import 'package:firebase_core/firebase_core.dart';
 import 'package:cloud_functions/cloud_functions.dart';
 import 'package:cloud_functions_platform_interface/cloud_functions_platform_interface.dart';
 import 'package:flutter_test/flutter_test.dart';
+import 'package:mockito/mockito.dart';
 
 import 'mock.dart';
 
-import 'package:mockito/mockito.dart';
-
 void main() {
   setupFirebaseFunctionsMocks();
   FirebaseFunctions functions;
@@ -29,7 +28,7 @@ void main() {
 
       secondaryApp = await Firebase.initializeApp(
           name: 'foo',
-          options: FirebaseOptions(
+          options: const FirebaseOptions(
             apiKey: '123',
             appId: '123',
             messagingSenderId: '123',

packages/cloud_functions/cloud_functions/test/https_callable_test.dart

@@ -8,10 +8,10 @@ import 'package:cloud_functions_platform_interface/cloud_functions_platform_inte
 import 'package:firebase_core/firebase_core.dart';
 import 'package:cloud_functions/cloud_functions.dart';
 import 'package:flutter_test/flutter_test.dart';
+import 'package:mockito/mockito.dart';
 
 import 'mock.dart';
 
-import 'package:mockito/mockito.dart';
 import 'sample.dart' as data;
 
 void main() {
@@ -43,8 +43,8 @@ void main() {
         return Future.value(kMockHttpsCallablePlatform);
       });
 
-      kHttpsCallable = functions.httpsCallable('test_name',
-          options: HttpsCallableOptions(timeout: Duration(minutes: 1)));
+      kHttpsCallable =
+          functions.httpsCallable('test_name', options: HttpsCallableOptions());
     });
 
     group('constructor', () {
@@ -61,7 +61,7 @@ void main() {
 
       test('accepts null', () async {
         expect(await kHttpsCallable(null), isA<HttpsCallableResult>());
-        verify(kMockHttpsCallablePlatform.call(null));
+        verify(kMockHttpsCallablePlatform.call());
       });
 
       test('accepts String', () async {

packages/cloud_functions/cloud_functions/test/mock.dart

@@ -12,16 +12,16 @@ import 'package:flutter_test/flutter_test.dart';
 import 'package:mockito/mockito.dart';
 import 'package:plugin_platform_interface/plugin_platform_interface.dart';
 
-typedef Callback(MethodCall call);
+typedef Callback = Function(MethodCall call);
 
-final String kTestString = 'Hello World';
-final String kBucket = 'gs://fake-storage-bucket-url.com';
-final String kSecondaryBucket = 'gs://fake-storage-bucket-url-2.com';
+const String kTestString = 'Hello World';
+const String kBucket = 'gs://fake-storage-bucket-url.com';
+const String kSecondaryBucket = 'gs://fake-storage-bucket-url-2.com';
 MockFirebaseFunctionsPlatform kMockFirebaseFunctionsPlatform;
 final MockHttpsCallablePlatform kMockHttpsCallablePlatform =
     MockHttpsCallablePlatform();
 
-setupFirebaseFunctionsMocks() {
+void setupFirebaseFunctionsMocks() {
   TestWidgetsFlutterBinding.ensureInitialized();
 
   MethodChannelFirebase.channel.setMockMethodCallHandler((call) async {
@@ -57,24 +57,31 @@ setupFirebaseFunctionsMocks() {
 
 // FirebaseFunctionsPlatform Mock
 class MockFirebaseFunctionsPlatform extends Mock
-    with MockPlatformInterfaceMixin
-    implements TestFirebaseFunctionsPlatform {
+    with
+        // ignore: prefer_mixin, plugin_platform_interface needs to migrate to use `mixin`
+        MockPlatformInterfaceMixin
+    implements
+        TestFirebaseFunctionsPlatform {
   MockFirebaseFunctionsPlatform(FirebaseApp app, String region) {
     TestFirebaseFunctionsPlatform(app, region);
   }
 }
 
 // HttpsCallablePlatform Mock
 class MockHttpsCallablePlatform extends Mock
-    with MockPlatformInterfaceMixin
-    implements HttpsCallablePlatform {}
+    with
+        // ignore: prefer_mixin, plugin_platform_interface needs to migrate to use `mixin`
+        MockPlatformInterfaceMixin
+    implements
+        HttpsCallablePlatform {}
 
 class TestFirebaseFunctionsPlatform extends FirebaseFunctionsPlatform {
   TestFirebaseFunctionsPlatform(FirebaseApp app, String region)
       : super(app, region);
 
-  instanceFor({FirebaseApp app, Map<dynamic, dynamic> pluginConstants}) {}
+  void instanceFor({FirebaseApp app, Map<dynamic, dynamic> pluginConstants}) {}
 
+  @override
   FirebaseFunctionsPlatform delegateFor({FirebaseApp app, String region}) {
     return this;
   }

packages/cloud_functions/cloud_functions_platform_interface/lib/cloud_functions_platform_interface.dart

@@ -6,7 +6,7 @@
 
 library cloud_functions_platform_interface;
 
+export 'src/firebase_functions_exception.dart';
+export 'src/https_callable_options.dart';
 export 'src/platform_interface/platform_interface_firebase_functions.dart';
 export 'src/platform_interface/platform_interface_https_callable.dart';
-export 'src/https_callable_options.dart';
-export 'src/firebase_functions_exception.dart';

packages/cloud_functions/cloud_functions_platform_interface/lib/src/firebase_functions_exception.dart

@@ -18,7 +18,11 @@ class FirebaseFunctionsException extends FirebaseException
     String code,
     StackTrace stackTrace,
     this.details,
-  }) : super(plugin: 'firebase_functions', message: message, code: code);
+  }) : super(
+            plugin: 'firebase_functions',
+            message: message,
+            code: code,
+            stackTrace: stackTrace);
 
   /// Additional data provided with the exception.
   final dynamic details;

packages/cloud_functions/cloud_functions_platform_interface/lib/src/method_channel/method_channel_firebase_functions.dart

@@ -4,14 +4,25 @@
 
 // @dart=2.9
 
-import 'package:cloud_functions_platform_interface/cloud_functions_platform_interface.dart';
 import 'package:firebase_core/firebase_core.dart';
 import 'package:flutter/services.dart';
 
+import '../../cloud_functions_platform_interface.dart';
 import 'method_channel_https_callable.dart';
 
 /// Method Channel delegate for [FirebaseFunctionsPlatform].
 class MethodChannelFirebaseFunctions extends FirebaseFunctionsPlatform {
+  /// Creates a new [MethodChannelFirebaseFunctions] instance with an [app] and/or
+  /// [region].
+  MethodChannelFirebaseFunctions({FirebaseApp app, String region})
+      : super(app, region);
+
+  /// Internal stub class initializer.
+  ///
+  /// When the user code calls a functions method, the real instance is
+  /// then initialized via the [delegateFor] method.
+  MethodChannelFirebaseFunctions._() : super(null, null);
+
   /// Returns a stub instance to allow the platform interface to access
   /// the class instance statically.
   static MethodChannelFirebaseFunctions get instance {
@@ -23,23 +34,14 @@ class MethodChannelFirebaseFunctions extends FirebaseFunctionsPlatform {
     'plugins.flutter.io/firebase_functions',
   );
 
-  /// Internal stub class initializer.
-  ///
-  /// When the user code calls a functions method, the real instance is
-  /// then initialized via the [delegateFor] method.
-  MethodChannelFirebaseFunctions._() : super(null, null);
-
-  /// Creates a new [MethodChannelFirebaseFunctions] instance with an [app] and/or
-  /// [region].
-  MethodChannelFirebaseFunctions({FirebaseApp app, String region})
-      : super(app, region);
-
+  @override
   FirebaseFunctionsPlatform delegateFor({FirebaseApp app, String region}) {
     return MethodChannelFirebaseFunctions(app: app, region: region);
   }
 
   @override
-  httpsCallable(String origin, String name, HttpsCallableOptions options) {
+  HttpsCallablePlatform httpsCallable(
+      String origin, String name, HttpsCallableOptions options) {
     return MethodChannelHttpsCallable(this, origin, name, options);
   }
 }