Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apphosting emulator - local secrets support via apphosting:config:export command #7831

Merged
merged 44 commits into from
Oct 31, 2024
Merged
Changes from 1 commit
Commits
Show all changes
44 commits
Select commit Hold shift + click to select a range
4c6676c
progress
mathu97 Oct 11, 2024
a1dc337
progress
mathu97 Oct 11, 2024
06694d6
working apphosting config readability
mathu97 Oct 16, 2024
b1dad2a
progress
mathu97 Oct 16, 2024
900e07a
progress
mathu97 Oct 18, 2024
2e04cf9
somewhat working export
mathu97 Oct 22, 2024
baf7474
fix eslint errors
mathu97 Oct 22, 2024
ea766ed
fix allYamlPaths and add unit tests
mathu97 Oct 22, 2024
f4129ed
add jsdoc
mathu97 Oct 22, 2024
25bdfd0
rename to match other functions
mathu97 Oct 22, 2024
3bbc94d
add tests to writeReadableConfigToAppHostingLocal
mathu97 Oct 23, 2024
f370372
add basic tests for secrets/index
mathu97 Oct 24, 2024
796ff31
complete tests
mathu97 Oct 24, 2024
07723e1
refactor and add some more tests
mathu97 Oct 24, 2024
d63a302
fix tests
mathu97 Oct 24, 2024
f4b35c8
Merge remote-tracking branch 'origin/master' into apphosting-emulator…
mathu97 Oct 24, 2024
e75d876
big refactor / clean up
mathu97 Oct 24, 2024
adfb574
add tests for yaml.ts
mathu97 Oct 24, 2024
b599b63
remove log
mathu97 Oct 24, 2024
f52f1e8
undo unnecessary change
mathu97 Oct 24, 2024
38dd105
Merge remote-tracking branch 'origin/master' into apphosting-emulator…
mathu97 Oct 24, 2024
296dfba
fix linting error
mathu97 Oct 24, 2024
a272fc2
fixup jsdocs
mathu97 Oct 24, 2024
273e6f5
naming consistency fixup
mathu97 Oct 28, 2024
a31f205
rename list function and use regex to match apphosting.yaml files
mathu97 Oct 28, 2024
688b21e
refactor
mathu97 Oct 28, 2024
e160818
implement more effecient secret fetching
mathu97 Oct 28, 2024
6069321
support --secrets and address comments
mathu97 Oct 28, 2024
11f51db
more fixes
mathu97 Oct 28, 2024
0643d6a
refactor yaml class to use factory pattern
mathu97 Oct 29, 2024
f5f2c58
further refactor of yaml class - don't keep track of filePath in state
mathu97 Oct 29, 2024
6815161
Merge remote-tracking branch 'origin/master' into apphosting-emulator…
mathu97 Oct 29, 2024
1f3c625
fix apphosting yaml regex
mathu97 Oct 30, 2024
4cb46ec
more refactor / clean up
mathu97 Oct 30, 2024
6d9b5f7
Merge remote-tracking branch 'origin/master' into apphosting-emulator…
mathu97 Oct 30, 2024
efacb7a
refactor apphosting file discovery
mathu97 Oct 30, 2024
e636a21
Merge remote-tracking branch 'origin/master' into apphosting-emulator…
mathu97 Oct 30, 2024
63e2190
address comments
mathu97 Oct 31, 2024
3590f95
minor fixes
mathu97 Oct 31, 2024
fbca80b
fix error message
mathu97 Oct 31, 2024
7248c0c
fix test
mathu97 Oct 31, 2024
1196c5b
fix naming
mathu97 Oct 31, 2024
8b7c06f
Merge remote-tracking branch 'origin/master' into apphosting-emulator…
mathu97 Oct 31, 2024
cc6e0d3
fix test
mathu97 Oct 31, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix linting error
  • Loading branch information
mathu97 committed Oct 24, 2024
commit 296dfba50ad11b228dd24f6e2914d834ab71adca
1 change: 0 additions & 1 deletion src/commands/apphosting-config-export.ts
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@ export const command = new Command("apphosting:config:export")

// Load apphosting.local.yaml file if it exists. Secrets should be added to the env list in this object and written back to the apphosting.local.yaml
const apphostingLocalConfigPath = yamlPath(currentDir, APPHOSTING_LOCAL_YAML);
logger.info(`apphostinglocal conifg path: ${apphostingLocalConfigPath}`)
const localAppHostingConfig = await loadAppHostingYaml(apphostingLocalConfigPath ?? undefined);

const configsToExport = await getConfigToExport(yamlFilePaths);
mathu97 marked this conversation as resolved.
Show resolved Hide resolved
Expand Down
Loading