New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apphosting emulator - local secrets support via `apphosting:config:export` command #7831

Merged

mathu97 merged 44 commits into master from apphosting-emulator/pull-secrets

Oct 31, 2024

Contributor

mathu97 commented Oct 14, 2024 •

edited

Loading

Adds a new command apphosting:config:export to export secrets (and other configurations in the future).

This new command reads from the chosen apphosting files present in the user's project codebase, hits Google Secret Manager to get the values of theses secrets, and writes them to the apphosting.local.yaml file. The apphosting.local.yaml file is automatically loaded into the app hosting emulator when firebase emulators:start is run.

mathu97 added 6 commits

October 11, 2024 18:59


          progress

4c6676c


          progress

a1dc337


          working apphosting config readability

06694d6


          progress

b1dad2a


          progress

900e07a


          somewhat working export

2e04cf9

mathu97 commented

View reviewed changes

src/apphosting/config.ts Outdated Show resolved Hide resolved

mathu97 commented

View reviewed changes

src/apphosting/config.ts Outdated Show resolved Hide resolved

mathu97 commented

View reviewed changes

src/apphosting/config.ts Outdated Show resolved Hide resolved

mathu97 commented

View reviewed changes

src/apphosting/config.ts Outdated Show resolved Hide resolved

mathu97 commented

View reviewed changes

src/apphosting/secrets/index.ts Outdated Show resolved Hide resolved

mathu97 commented

View reviewed changes

src/apphosting/secrets/index.ts Outdated Show resolved Hide resolved

mathu97 commented

View reviewed changes

src/apphosting/secrets/index.ts Outdated Show resolved Hide resolved

mathu97 commented

View reviewed changes

src/apphosting/utils.ts Outdated Show resolved Hide resolved

mathu97 added 14 commits

October 22, 2024 17:39


          fix eslint errors

baf7474


          fix allYamlPaths and add unit tests

ea766ed


          add jsdoc

f4129ed


          rename to match other functions

25bdfd0


          add tests to writeReadableConfigToAppHostingLocal

3bbc94d


          add basic tests for secrets/index

f370372


          complete tests

796ff31


          refactor and add some more tests

07723e1


          fix tests

d63a302


          Merge remote-tracking branch 'origin/master' into apphosting-emulator…

f4b35c8

…/pull-secrets


          big refactor / clean up

e75d876


          add tests for yaml.ts

adfb574


          remove log

b599b63


          undo unnecessary change

f52f1e8

mathu97 requested review from tonyjhuang and taeold

October 24, 2024 21:04

mathu97 added 6 commits

October 28, 2024 17:18


          refactor

688b21e


          implement more effecient secret fetching

e160818


          support --secrets and address comments


          more fixes

11f51db


          refactor yaml class to use factory pattern

0643d6a


          further refactor of yaml class - don't keep track of filePath in state

f5f2c58

mathu97 requested a review from tonyjhuang

October 29, 2024 04:05


          Merge remote-tracking branch 'origin/master' into apphosting-emulator…

…/pull-secrets

tonyjhuang requested changes

View reviewed changes

src/apphosting/config.ts Outdated Show resolved Hide resolved

src/apphosting/secrets/index.ts Outdated Show resolved Hide resolved

src/apphosting/config.ts Outdated Show resolved Hide resolved

src/apphosting/config.ts Outdated Show resolved Hide resolved

src/apphosting/secrets/index.ts Outdated Show resolved Hide resolved

src/apphosting/yaml.ts Show resolved Hide resolved

src/apphosting/yaml.ts Outdated Show resolved Hide resolved

src/apphosting/yaml.ts Outdated Show resolved Hide resolved

src/commands/apphosting-config-export.ts Outdated Show resolved Hide resolved

src/commands/apphosting-config-export.ts Outdated Show resolved Hide resolved

mathu97 added 3 commits

October 30, 2024 00:39


          fix apphosting yaml regex

1f3c625


          more refactor / clean up

4cb46ec


          Merge remote-tracking branch 'origin/master' into apphosting-emulator…

6d9b5f7

…/pull-secrets

mathu97 requested a review from tonyjhuang

October 30, 2024 20:14

mathu97 added 2 commits

October 30, 2024 23:06


          refactor apphosting file discovery

efacb7a


          Merge remote-tracking branch 'origin/master' into apphosting-emulator…

e636a21

…/pull-secrets

tonyjhuang requested changes

View reviewed changes

src/apphosting/secrets/index.ts Show resolved Hide resolved

src/apphosting/secrets/index.ts Show resolved Hide resolved

src/apphosting/utils.ts Outdated Show resolved Hide resolved

src/apphosting/utils.ts Outdated Show resolved Hide resolved

src/apphosting/config.ts Outdated Show resolved Hide resolved

src/apphosting/yaml.ts Outdated Show resolved Hide resolved

src/apphosting/yaml.ts Outdated Show resolved Hide resolved

src/commands/apphosting-config-export.ts Outdated Show resolved Hide resolved

src/commands/apphosting-config-export.ts Outdated Show resolved Hide resolved

src/emulator/apphosting/config.ts Outdated Show resolved Hide resolved

mathu97 added 2 commits

October 31, 2024 06:44


          address comments

63e2190


          minor fixes

3590f95

mathu97 requested a review from tonyjhuang

October 31, 2024 15:26

tonyjhuang requested changes

View reviewed changes

src/apphosting/config.ts Outdated Show resolved Hide resolved

src/commands/apphosting-config-export.ts Outdated Show resolved Hide resolved

src/emulator/apphosting/config.ts Outdated Show resolved Hide resolved


          fix error message

fbca80b

mathu97 requested a review from tonyjhuang

October 31, 2024 16:36


          fix test

7248c0c

tonyjhuang approved these changes

View reviewed changes

Contributor

tonyjhuang left a comment

thanks for all the changes! 🔥🔥

src/apphosting/utils.ts Outdated Show resolved Hide resolved

src/apphosting/yaml.ts Outdated Show resolved Hide resolved

mathu97 added 2 commits

October 31, 2024 18:09


          fix naming

1196c5b


          Merge remote-tracking branch 'origin/master' into apphosting-emulator…

8b7c06f

…/pull-secrets

mathu97 enabled auto-merge (squash)

October 31, 2024 18:09


          fix test

cc6e0d3

mathu97 merged commit 54d6aa7 into master

42 of 45 checks passed

mathu97 deleted the apphosting-emulator/pull-secrets branch

October 31, 2024 18:37

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet