Skip to content

Update old error messages on valid nodejs runtimes. #5784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 3, 2023
Merged

Update old error messages on valid nodejs runtimes. #5784

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c973b86
Update old error messages on valid nodejs runtimes.
taeold May 2, 2023
185dd20
Merge branch 'master' into dl-update-err-msgs
joehan May 2, 2023
6be79a4
Merge branch 'master' into dl-update-err-msgs
joehan May 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/deploy/functions/runtimes/node/parseRuntimeAndValidateSDK.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,16 +24,16 @@ const ENGINE_RUNTIMES_NAMES = Object.values(ENGINE_RUNTIMES);
export const RUNTIME_NOT_SET =
"`runtime` field is required but was not found in firebase.json.\n" +
"To fix this, add the following lines to the `functions` section of your firebase.json:\n" +
'"runtime": "nodejs16"\n';
'"runtime": "nodejs18"\n';

export const UNSUPPORTED_NODE_VERSION_FIREBASE_JSON_MSG = clc.bold(
`functions.runtime value is unsupported. ` +
`Valid choices are: ${clc.bold("nodejs{10|12|14|16}")}.`
`Valid choices are: ${clc.bold("nodejs{10|12|14|16|18}")}.`
Copy link
Contributor

@joehan joehan May 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL that GCF still supports node 10: https://cloud.google.com/functions/docs/concepts/nodejs-runtime

);

export const UNSUPPORTED_NODE_VERSION_PACKAGE_JSON_MSG = clc.bold(
`package.json in functions directory has an engines field which is unsupported. ` +
`Valid choices are: ${clc.bold('{"node": 10|12|14|16}')}`
`Valid choices are: ${clc.bold('{"node": 10|12|14|16|18}')}`
);

export const DEPRECATED_NODE_VERSION_INFO =
Expand Down