Update old error messages on valid nodejs runtimes. #5784
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joehan
approved these changes
May 2, 2023
| export const UNSUPPORTED_NODE_VERSION_FIREBASE_JSON_MSG = clc.bold( | ||
| `functions.runtime value is unsupported. ` + | ||
| `Valid choices are: ${clc.bold("nodejs{10|12|14|16}")}.` | ||
| `Valid choices are: ${clc.bold("nodejs{10|12|14|16|18}")}.` |
Contributor
There was a problem hiding this comment.
TIL that GCF still supports node 10: https://cloud.google.com/functions/docs/concepts/nodejs-runtime
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #5784 +/- ##
=======================================
Coverage 55.19% 55.19%
=======================================
Files 329 329
Lines 22527 22527
Branches 4590 4590
=======================================
Hits 12434 12434
Misses 8989 8989
Partials 1104 1104 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ProfHercules
pushed a commit
to ProfHercules/firebase-tools
that referenced
this pull request
May 5, 2023
Co-authored-by: joehan <joehanley@google.com>
tonyjhuang
pushed a commit
that referenced
this pull request
May 22, 2023
Co-authored-by: joehan <joehanley@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reported in #5755