Use google-closure-deps instead of depswriter.py.

[kjin]

In Closure Library, we will be removing depswriter.py and other Python-based build scripts soon. depswriter.py is superceded by google-closure-deps, a similar tool we maintain that is implemented in Node.js.

Here, I've substituted the depswriter.py command with a corresponding command from google-closure-deps; the CLI flags are similar. The difference in output is minimal (see below).

Explanation of "extra" flags:

• --closure-path="node_modules/google-closure-library/closure/goog" Path to Closure (now required)
• --file="node_modules/google-closure-library/closure/goog/deps.js" Use the deps.js file bundled with Closure as part of deps calculation
• --exclude=... Not strictly necessary, but prevents these files from being written to deps.js as trivial, 0-dependency entries

For reference, the diff of the resulting deps.js from running npm run generate-test-files (with lines sorted and formatted for diff clarity) is here.

Fixes #4848

See also firebase/firebaseui-web#839

[changeset-bot]

⚠️ No Changeset found

Latest commit: 4f7ff9f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[kjin]

@bojeil-google Friendly ping, you approved a similar PR of mine in firebaseui-web, do you mind taking a look at this as well? Thanks!

[sam-gc]

I can also approve this change-- have you run the program in question to verify the update works? I can also do it but if you've already done it I won't double check

[kjin]

@sam-gc Ah, for some reason I had thought I needed two approvers. I think I did, but let me double check

[sam-gc]

Sounds good, when you're done you can go ahead and merge

[kjin]

@sam-gc I'm running into trouble running any of the commands that use the generated deps.js file. yarn serve seems to hang and yarn test also hangs after some tests fail (both on master and with this change). I'm pretty confident the changes here are not functionally different (see the linked deps.js comparison in my PR description), could you confirm this on your side and land it? Thanks! (I can't merge it anyway)

[sam-gc]

Okay, I'll take a look tomorrow

[Feiyang1]

Any updates?

[kjin]

Ping @sam-gc -- anything else that needs to be done here?