Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate off depswriter.py #4848

Open
kjin opened this issue Apr 28, 2021 · 1 comment · May be fixed by #4849
Open

Migrate off depswriter.py #4848

kjin opened this issue Apr 28, 2021 · 1 comment · May be fixed by #4849
Assignees
@sam-gc
Labels
api: auth bug internal-bug-filed

Comments

@kjin
Copy link
Contributor

kjin commented Apr 28, 2021 •
edited
Loading

[REQUIRED] Describe your environment

  • Operating System version: N/A
  • Browser version: N/A
  • Firebase SDK version: N/A
  • Firebase Product: auth

[REQUIRED] Describe the problem

In Closure Library, we will be removing depswriter.py and other Python-based build scripts soon. depswriter.py is superceded by google-closure-deps, a similar tool we maintain that is implemented in Node.js.

depswriter.py is used in this file, so it will need to be migrated.

I've already created the change and opened a PR here: #4849
@kjin kjin linked a pull request Apr 28, 2021 that will close this issue
Open
@Feiyang1 Feiyang1 assigned sam-gc and unassigned Feiyang1 May 5, 2021
@weixifan
Copy link

Hi, I've created b/188396942 to track this.

@DellaBitta DellaBitta added the bug label Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sam-gc sam-gc

Labels
api: auth bug internal-bug-filed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use google-closure-deps instead of depswriter.py. kjin/firebase-js-sdk
6 participants
@kjin @sam-gc @Feiyang1 @DellaBitta @google-oss-bot @weixifan