Skip to content

[CI] Run check workflow on Ubuntu #14534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Mar 6, 2025
Merged

[CI] Run check workflow on Ubuntu #14534

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
df1e815
[CI] Run `check` workflow on Ubuntu
andrewheard Mar 5, 2025
f1f2237
Move `brew` commands into one step
andrewheard Mar 5, 2025
9802624
Remove "Install Mint and clang-format" step; done in `scripts/setup_…
andrewheard Mar 5, 2025
dce60e9
Fix `FIR_CLANG_FORMAT_PATH`
andrewheard Mar 5, 2025
7f2f34e
Add brew to shell env
andrewheard Mar 5, 2025
9c7fd11
echo Swift install location
andrewheard Mar 5, 2025
935fe4e
Remove echo of Swift install location
andrewheard Mar 5, 2025
f1f2f4d
Add Homebrew `clang-format` to front of `PATH`
andrewheard Mar 5, 2025
584581a
Update `PATH` directly instead of `.bash_profile`
andrewheard Mar 5, 2025
76218ec
Move to `Check` step
andrewheard Mar 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions .github/workflows/check.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:
check:
# Don't run on private repo.
if: github.repository == 'Firebase/firebase-ios-sdk'
runs-on: macos-14
runs-on: ubuntu-latest
env:
MINT_PATH: ${{ github.workspace }}/mint
steps:
Expand All @@ -33,7 +33,13 @@ jobs:
restore-keys: ${{ runner.os }}-mint-

- name: Setup check
run: scripts/setup_check.sh
run: |
eval "$(/home/linuxbrew/.linuxbrew/bin/brew shellenv)"
scripts/setup_check.sh

- name: Check
run: scripts/check.sh --test-only
run: |
eval "$(/home/linuxbrew/.linuxbrew/bin/brew shellenv)"
# Add Homebrew clang-format to first in PATH
export PATH="/home/linuxbrew/.linuxbrew/opt/clang-format/bin:$PATH"
scripts/check.sh --test-only
2 changes: 1 addition & 1 deletion scripts/check.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,7 +290,7 @@ python --version
"${top_dir}/scripts/check_filename_spaces.sh"
"${top_dir}/scripts/check_copyright.sh"
"${top_dir}/scripts/check_test_inclusion.py"
"${top_dir}/scripts/check_imports.swift"
swift "${top_dir}/scripts/check_imports.swift"

# Google C++ style
lint_cmd=("${top_dir}/scripts/check_lint.py")
Expand Down
Loading