Skip to content

[CI] Run check workflow on Ubuntu #14534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Mar 6, 2025
Merged

[CI] Run check workflow on Ubuntu #14534

merged 10 commits into from
Mar 6, 2025

Conversation

andrewheard
Copy link
Contributor

Updated the check workflow run on ubuntu-latest instead of macos-14.

#no-changelog

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @andrewheard, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

Summary of Changes

This pull request updates the CI configuration to run the check workflow on Ubuntu instead of macOS. This involves modifying the .github/workflows/check.yml file to change the runs-on value and adding steps to set up the Homebrew path, install Mint, cache Mint packages, and install clang-format.

Highlights

  • CI Configuration: The check workflow is now configured to run on ubuntu-latest instead of macos-14.
  • Dependency Installation: The workflow now includes steps to install Mint and clang-format using Homebrew on Ubuntu.
  • Homebrew Setup: The workflow now sets up the Homebrew path to ensure that Mint and clang-format can be installed correctly.

Changelog

  • .github/workflows/check.yml
    • Changed runs-on from macos-14 to ubuntu-latest (line 18).
    • Added step to set up Homebrew path (lines 28-29).
    • Added step to install Mint using Homebrew (lines 31-32).
    • Added step to install clang-format using Homebrew (lines 41-45).
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.


Did you know?

Ubuntu is based on Debian architecture and infrastructure.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request updates the check workflow to run on Ubuntu instead of macOS, and includes necessary setup steps for the Ubuntu environment. The changes seem reasonable and well-structured.

Merge Readiness

The pull request appears to be in good shape. The changes are straightforward and address the intended goal of running the check workflow on Ubuntu. I am unable to directly approve the pull request, and recommend that others review and approve this code before merging.

@ncooke3
Copy link
Member

ncooke3 commented Mar 5, 2025

scripts/check.sh: line 293: /home/runner/work/firebase-ios-sdk/firebase-ios-sdk/scripts/check_imports.swift: cannot execute: required file not found

Maybe we need to add swift to $PATH?

@andrewheard
Copy link
Contributor Author

scripts/check.sh: line 293: /home/runner/work/firebase-ios-sdk/firebase-ios-sdk/scripts/check_imports.swift: cannot execute: required file not found

Maybe we need to add swift to $PATH?

@ncooke3 I think it's likely in a different spot and the script specifies:

Current CI run will print the install location if swift is already in the PATH 🤞

@andrewheard andrewheard marked this pull request as ready for review March 6, 2025 00:05
@andrewheard andrewheard requested review from paulb777 and ncooke3 March 6, 2025 00:07
Copy link
Member

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Copy link
Member

@ncooke3 ncooke3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@andrewheard andrewheard merged commit 81ab6f9 into main Mar 6, 2025
24 checks passed
@andrewheard andrewheard deleted the ah/check-style-linux branch March 6, 2025 15:23
@firebase firebase locked and limited conversation to collaborators Apr 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants