-
Notifications
You must be signed in to change notification settings - Fork 1.6k
[CI] Run check
workflow on Ubuntu
#14534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @andrewheard, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
Summary of Changes
This pull request updates the CI configuration to run the check
workflow on Ubuntu instead of macOS. This involves modifying the .github/workflows/check.yml
file to change the runs-on
value and adding steps to set up the Homebrew path, install Mint, cache Mint packages, and install clang-format.
Highlights
- CI Configuration: The
check
workflow is now configured to run onubuntu-latest
instead ofmacos-14
. - Dependency Installation: The workflow now includes steps to install Mint and clang-format using Homebrew on Ubuntu.
- Homebrew Setup: The workflow now sets up the Homebrew path to ensure that Mint and clang-format can be installed correctly.
Changelog
- .github/workflows/check.yml
- Changed
runs-on
frommacos-14
toubuntu-latest
(line 18). - Added step to set up Homebrew path (lines 28-29).
- Added step to install Mint using Homebrew (lines 31-32).
- Added step to install clang-format using Homebrew (lines 41-45).
- Changed
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Did you know?
Ubuntu is based on Debian architecture and infrastructure.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
The pull request updates the check
workflow to run on Ubuntu instead of macOS, and includes necessary setup steps for the Ubuntu environment. The changes seem reasonable and well-structured.
Merge Readiness
The pull request appears to be in good shape. The changes are straightforward and address the intended goal of running the check
workflow on Ubuntu. I am unable to directly approve the pull request, and recommend that others review and approve this code before merging.
scripts/check.sh: line 293: /home/runner/work/firebase-ios-sdk/firebase-ios-sdk/scripts/check_imports.swift: cannot execute: required file not found Maybe we need to add |
@ncooke3 I think it's likely in a different spot and the script specifies:
Current CI run will print the install location if |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Updated the
check
workflow run onubuntu-latest
instead ofmacos-14
.#no-changelog