-
Notifications
You must be signed in to change notification settings - Fork 1.6k
[Functions] Add support for streamable cloud functions #14395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
114 commits
Select commit
Hold shift + click to select a range
231d602
[Infra] Update functions workflow to use macOS 15 for Xcode 16 jobs (…
eBlender a14d964
Stremable Functions.
eBlender a92d7c2
Changed return type.
eBlender 10bec1d
Lint test
eBlender 53a2aab
Remove test function
eBlender 758fbed
Remove old test.
eBlender 93b6c8b
Updated function, add full test.
eBlender a7e8fe8
Update functions
eBlender 6d59fcd
Update FunctionsTests.swift
eBlender 51f02b8
Cleanup HTTPCallable
eBlender 7b61076
Add documentation for processResponseDataForStreamableContent
eBlender a95449e
Update Functions.swift
eBlender cdc49ee
Update Functions.swift
eBlender 426b6bc
Update FunctionsTests.swift
eBlender 9cb0a5e
Update and Cleanup
eBlender ad31052
Update IntegrationTests.swift
eBlender 6ee9000
Clean up
eBlender 1ffe73d
Update check.sh
eBlender 9fcd91e
Bump to Main.
eBlender 177aa8e
Merge branch 'main' into iOS-Stremable-Functions
eBlender f4d678b
Cleanup
eBlender 74557e7
Merge branch 'iOS-Stremable-Functions' of https://github.com/eBlender…
eBlender 18f748b
Update Functions.swift
eBlender 4f956fb
Lint check
eBlender 4edc0ad
Function concurrency error
eBlender e50f69c
Update .github/workflows/functions.yml
eBlender 7356cf9
Update FirebaseFunctions/Tests/Unit/FunctionsTests.swift
eBlender aed47d6
Delete firebase-database-emulator.log
eBlender f6c6cff
Delete firebase-database-emulator.pid
eBlender 75a7574
Update function error handling.
eBlender adf7366
Merge branch 'iOS-Stremable-Functions' of https://github.com/eBlender…
eBlender 9ef7411
Update FirebaseFunctions/Tests/Unit/FunctionsTests.swift
eBlender 4ee820e
Update FunctionsTests.swift
eBlender fd68f01
Merge branch 'iOS-Stremable-Functions' of https://github.com/eBlender…
eBlender f27bf07
Update FunctionsTests.swift
eBlender 1ffa4f0
Format and refactoring.
eBlender 80f0991
Update FirebaseFunctions/Tests/Unit/FunctionsTests.swift
eBlender 756dc26
Update FirebaseFunctions/Tests/Unit/FunctionsTests.swift
eBlender f031c1f
Update FirebaseFunctions/Tests/Unit/FunctionsTests.swift
eBlender 0df7f8d
Update FirebaseFunctions/Tests/Unit/FunctionsTests.swift
eBlender 3e325aa
[WIP] Add generic and basic streaming implementation
ncooke3 95fc340
Merge branch 'main' into iOS-Stremable-Functions
ncooke3 a712525
Merge branch 'main' into iOS-Stremable-Functions
ncooke3 7b42c35
Move unit tests
ncooke3 6dc3959
Merge remote-tracking branch 'origin/main' into iOS-Stremable-Functions
ncooke3 ca53153
Post main sync checkpoint
ncooke3 d3e476c
Copy over more structure from vertex
ncooke3 e33f74c
Updated to changes in 14376 so the impl is closer to Vertex on how th…
ncooke3 b98f71d
Update - remove tests
eBlender 0ea118f
Add Documentation.
eBlender 20892fd
Update Functions.swift
eBlender 83eae53
Update IntegrationTests.swift
eBlender 749b52d
Add more integration tests
ncooke3 480f7c3
Remove unneeded code
ncooke3 5587eb7
Fix comments
ncooke3 078210e
Rename internal stream API
ncooke3 caeff20
Streamable functions - Continuation of #14395 (#14465)
eBlender e68b47e
Style and fix TODOs
ncooke3 2aca67e
Decode StreamResponse
ncooke3 5fcaf4a
Update integration tests
ncooke3 e59368e
Intermediate fix for message decoding
ncooke3 1d75275
emulator backend add test
ncooke3 4b19247
Custom StreamResponse decoding and add more todos
ncooke3 b953f58
Don't decode result if stream response is not used
ncooke3 b8d32c9
Generalize decoding logic
ncooke3 659a19d
Only decode result in StreamResponse and throw FunctionErrors only
ncooke3 79b23c9
Resolve TODO & move availability attribute
ncooke3 5a7275e
Streamable functions api signature change (#14502)
eBlender 1b8b700
Clean up tests following API sig. change
ncooke3 cb24822
Add changelog entry
ncooke3 fe17eb2
Remove unreleased API in emulator backend
ncooke3 10576c1
Remove unneeded availability attribute
ncooke3 b05d6f3
Resolve more testing TODOs
ncooke3 9de03a5
refactor private types
ncooke3 e2cf5f4
Add EmptyRequest type to represent parameter-less CF3
ncooke3 54967a8
Update doc comment
ncooke3 84b2950
Remove TODO that is no longer needed
ncooke3 60b4e6e
Remove unit test related TODO
ncooke3 672c5ed
Add doc header
ncooke3 a8313c0
Add doc comment for streamresponse
ncooke3 f9c557f
Apply suggestions from code review
ncooke3 2a55348
Review refactor
ncooke3 949bd63
Remove oos TODO
ncooke3 53c2560
Shorten test wait time to 100ms
ncooke3 2d59914
Docs
ncooke3 3723560
Add more info to doc comment
ncooke3 9be0b82
Wrap doc comment lines
ncooke3 3d709d8
Minor changes
ncooke3 bf21148
Remove unit tests
ncooke3 28bc4ed
Merge branch 'main' into streamable-functions
ncooke3 938bccf
Add test for Never
ncooke3 c9ce046
Add test for streaming non-streaming cf3
ncooke3 e19fa08
Add more tests
ncooke3 17f6898
Add top-level comment
ncooke3 3cf14bf
Add comment
ncooke3 fba5966
functions.yml
ncooke3 da798aa
[test] fix ci workaround
ncooke3 1a376f6
Fix availability check
ncooke3 ca67754
review (1)
ncooke3 65455ec
review (2)
ncooke3 f06ebf0
review (3) - line limit
ncooke3 9cf8c2c
review (4) - line limit (code)
ncooke3 887d139
Merge branch 'main' into streamable-functions
ncooke3 4b4bac6
Merge branch 'main' into streamable-functions
ncooke3 7e7e5f4
Post merge fix
ncooke3 f7da23e
Undo change
ncooke3 36821d0
rename test
ncooke3 c533101
small nit
ncooke3 ec33fa8
sendability
ncooke3 6da863b
Remote --test-spec
ncooke3 14058ba
Remove downloading iOS sim
ncooke3 4847a34
review
ncooke3 2f22696
review 2
ncooke3 66a7478
visionos ci fix
ncooke3 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.