-
Notifications
You must be signed in to change notification settings - Fork 1.6k
[Functions] Add support for streamable cloud functions #14395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add initial support for Streamable functions.
Change call to AsyncThrowingStream<HTTPSCallableResult, Error>
Remove old test function.
Remove old test
Add a full working test for stremableFunction. Refactor.
Add Json capabilities to parse an HTTP result back and forth. Updating Unit tests.
Cleanup
Add doc for processResponseDataForStreamableContent.
Update func to have a callback. Update UnitTests
Remove test.
Fetch Main branch.
…/firebase-ios-sdk into iOS-Stremable-Functions
Updated to renamed code. From callableResultFromResponse to callableResult
Run style.sh
Fix concurrency " mutation of captured var 'response' in concurrently-executing code" and typos.
Co-authored-by: Nick Cooke <36927374+ncooke3@users.noreply.github.com>
Co-authored-by: Nick Cooke <36927374+ncooke3@users.noreply.github.com>
This file is not needed.
This file is not needed.
Add throws Remove DO - CATCH
andrewheard
approved these changes
Mar 4, 2025
/gemini please review |
Okay, I will review the pull request now. |
/gemini Still reviewing? |
It appears I am still reviewing the pull request. I will provide feedback as soon as possible. |
paulb777
approved these changes
Mar 7, 2025
This should be in a good state. I'll address any further comments in a follow-up PR. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
go/cf3-callable-streaming-clients-ios
Android PR: firebase/firebase-android-sdk#6602
Contribution Workflow
git remote add upstream https://github.com/firebase/firebase-ios-sdk.git
git fetch upstream && git checkout -b <feature-branch> upstream/streamable-functions
<feature-branch>
is the name of the branch (e.g., add-tests-streamable).git add . && git commit -m "..."
git push origin <feature-branch>
firebase:streamable-functions