Fix zip bloat issue #10183
Merged
Fix zip bloat issue #10183
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
ncooke3
approved these changes
Sep 7, 2022
akmarinov
pushed a commit
to combyne/firebase-ios-sdk
that referenced
this pull request
Sep 29, 2022
…nto inapp-customization * 'release/9.6.0' of github.com:combyne/firebase-ios-sdk: (116 commits) Fix typo (firebase#10196) Fix zip bloat issue (firebase#10183) Add All and Infrastructure as product options (firebase#10185) [v9.6.0] Update CHANGELOGs for macOS keychain fix (firebase#10181) Add API tests for Analytics.sessionID() (firebase#10178) [CoreInternal] Add explicit generics typing for Array.Index usage (2) (firebase#10176) [Infra] Commits should exclude .build/ folder from nested dirs (firebase#10180) [Messaging] macOS keychain auth prompt fix (firebase#10166) Analytics 9.6.0 (firebase#10177) Fix index backfilling frequency (firebase#10173) Add protos for COUNT (firebase#10175) Fix name collision with "result" in pretty printing logic in generated proto code. (firebase#10169) firestore_client.cc: increase the kRegularBackfillDelay from 1ms to 1000ms (firebase#10170) [Core] Link WatchKit for watchOS (firebase#10157) [Core] Support watchOS lifecycle notifications (firebase#10112) Move zip and prerelease nightlies early (firebase#10152) Update versions for Release 9.6.0 (firebase#10145) [MLModelDownloader] Disable keychain-dependent tests on macCatalyst and macOS (firebase#10148) [AppCheck] Disable tests that use keychain (firebase#10146) Fix priority inversion issue exposed by Xcode 14 (firebase#10144) ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#10073 exposed an existing bug caused by conflating framework names and pod names, which led to FBLPromises.xcpromises being duplicated in every zip folder, eg
This PR fixes the issue by identifying the variable correctly as
frameworksToIgnoreand comparing against frameworks instead of pods.