Skip to content

Update versions for Release 9.6.0 #10145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 29, 2022
Merged

Update versions for Release 9.6.0 #10145

merged 2 commits into from
Aug 29, 2022

Conversation

andrewheard
Copy link
Contributor

@andrewheard andrewheard commented Aug 26, 2022 •
edited
Loading

Updated version numbers in preparation for the next Firebase release (9.6.0).

#no-changelog

@andrewheard andrewheard added this to the 9.6.0 - M121 milestone Aug 26, 2022
@andrewheard andrewheard self-assigned this Aug 26, 2022
paulb777
paulb777 approved these changes Aug 26, 2022
View reviewed changes
Copy link
Member

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on green

@google-oss-bot
Copy link

Size Report 1

Affected Products

  • FirebaseStorage

    TypeBase (737700d)Merge (1efb225)Diff
    CocoaPods866 kB866 kB+8 B (+0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/h8ZHuZ8RCw.html

@google-oss-bot
Copy link

google-oss-bot commented Aug 26, 2022 •
edited
Loading

Coverage Report 1

Affected Products

  • FirebaseDatabase-iOS-FirebaseDatabase.framework

    Overall coverage changed from 57.19% (f8ee68b) to 57.04% (23bb43d) by -0.15%.

    FilenameBase (f8ee68b)Merge (23bb43d)Diff
    FSRWebSocket.m40.54%38.52%-2.02%

  • FirebaseMessaging-iOS-FirebaseMessaging.framework

    Overall coverage changed from 63.88% (f8ee68b) to 63.95% (23bb43d) by +0.06%.

    FilenameBase (f8ee68b)Merge (23bb43d)Diff
    FIRMessagingPendingTopicsList.m89.02%90.59%+1.57%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/ljJUvqmNay.html

@ncooke3
Copy link
Member

ncooke3 commented Aug 26, 2022

Regarding some of the failures, the remoteconfig / watchOS one looks to be a flake of some kind. I've seen it appear in the nightlies.

The appcheck / macos is related to GoogleUtilities 7.8.0. The AppCheck tests need to be disabled on macOS. I will send a PR but feel free to not let that failure block you!

@ncooke3 ncooke3 mentioned this pull request Aug 26, 2022
Merged
1 task
@ncooke3
Copy link
Member

ncooke3 commented Aug 27, 2022

mlmodeldownloader / macos is related to keychain fix as well. I will disable offending tests on macOS. MLModelDownloader depends on Installations.

@ncooke3 ncooke3 mentioned this pull request Aug 28, 2022
Merged
1 task
@ncooke3
Copy link
Member

ncooke3 commented Aug 29, 2022

Two of the three failures have been addressed in merged PRs.

The remaining watchOS x remote config failure looks like a flake. Kicked off a deflake: https://github.com/firebase/firebase-ios-sdk/actions/runs/2936339297

@ncooke3
Copy link
Member

ncooke3 commented Aug 29, 2022

Two of the three failures have been addressed in merged PRs.

The remaining watchOS x remote config failure looks like a flake. Kicked off a deflake: https://github.com/firebase/firebase-ios-sdk/actions/runs/2936339297

Ok so the watchOS failure was indeed an integration flake.

@andrewheard, this PR is now unblocked.

@andrewheard andrewheard requested a review from ncooke3 August 29, 2022 17:00
ncooke3
ncooke3 approved these changes Aug 29, 2022
View reviewed changes
Copy link
Member

@ncooke3 ncooke3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewheard andrewheard merged commit efbb25d into master Aug 29, 2022
@andrewheard andrewheard deleted the version-9.6 branch August 29, 2022 22:07
charlotteliang pushed a commit that referenced this pull request Aug 31, 2022
@andrewheard @charlotteliang
Update versions for Release 9.6.0 (#10145)
c769b7e 
Updated version numbers in preparation for Firebase M121 (9.6.0).

#no-changelog
@firebase firebase locked and limited conversation to collaborators Sep 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@paulb777 paulb777 paulb777 approved these changes

@ncooke3 ncooke3 ncooke3 approved these changes

@charlotteliang charlotteliang Awaiting requested review from charlotteliang

Assignees

@andrewheard andrewheard

Labels
api: analytics api: appcheck api: appdistribution api: auth api: core api: crashlytics api: database api: dynamiclinks api: firestore api: functions api: inappmessaging Firebase In App Messaging api: installations api: messaging api: performance api: remoteconfig api: storage release-tooling
Projects
None yet
Milestone
9.6.0 - M121
Development

Successfully merging this pull request may close these issues.
4 participants
@andrewheard @google-oss-bot @ncooke3 @paulb777