Skip to content

Make screenshotUris non-optional. #1188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 11, 2022

Conversation

jladieu
Copy link
Contributor

@jladieu jladieu commented Aug 10, 2022

If omitted, they should be defaulted to an empty list.

Copy link
Member

@inlined inlined left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Starting on line 332, edit the following code:

  const func = (raw: CloudEvent<unknown>) => {
    return handler(raw as AppDistributionEvent<InAppFeedbackPayload>);
  };

to be:

const func = (raw: CloudEvent<unknown>) => {
  const event = raw as AppDistributionEvent<InAppFeedbackPayload>;
  // Consolidate the case of empty array and null array
  event.data.payload.screenshotUris = event.data.payload.screenshotUris || [];
  return handler(event);
};

If omitted, default to an empty list.
@jladieu jladieu force-pushed the jl/make-screenshot-uris-non-optional branch from b94b8c2 to a5f51e5 Compare August 11, 2022 01:04
@jladieu jladieu merged commit 0e4ffb6 into master Aug 11, 2022
@jladieu jladieu deleted the jl/make-screenshot-uris-non-optional branch August 11, 2022 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants