Add support for App Distribution in-app Feedback #1167
Conversation
kaibolay
force-pushed
the
appdistro-in-app-feedback
branch
3 times, most recently
from
d277573 to
0cc6154
Compare
I don't think so. I think it depends on http://cl/459802137 making it to production.
I had hoped you could tell me ;-) I'm not aware of any other missing pieces - please let me know if you can think of any. |
kaibolay
force-pushed
the
appdistro-in-app-feedback
branch
from
339cf9e to
d03ae88
Compare
|
/retest |
| /** Text entered by the tester */ | ||
| text: string; | ||
| /** URIs to download screenshot(s) */ | ||
| screenshotUris?: string[]; |
There was a problem hiding this comment.
Can we make this non-optional and always provide the empty array if necessary?
There was a problem hiding this comment.
Hi there, I'm on Kai's team and working on this while he's on vacation.
#1187 includes a fix for this feedback.
There was a problem hiding this comment.
Update on this...I put the fix for making screenshotUris non-optional into a different PR: #1188 because I don't know what I'm doing yet and don't want to couple the other changes in the originally-linked PR with this one :)
There was a problem hiding this comment.
No worries. I helped out in that PR.
Adding
InAppFeedbackPayloadandonNewInAppFeedbackPublished().